Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on pydantic<2.0 #109

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Depend on pydantic<2.0 #109

merged 2 commits into from
Jul 3, 2023

Conversation

reuterbal
Copy link
Collaborator

Hotfix to mitigate #108

@github-actions
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/109/index.html

@reuterbal reuterbal requested a review from mlange05 June 30, 2023 19:45
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #109 (f75f19c) into main (cffca77) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   92.15%   92.14%   -0.01%     
==========================================
  Files          89       89              
  Lines       16484    16484              
==========================================
- Hits        15191    15190       -1     
- Misses       1293     1294       +1     
Flag Coverage Δ
lint_rules 97.36% <ø> (ø)
loki 92.09% <ø> (-0.01%) ⬇️
transformations 91.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. GTG once codecov threshold adjusted.

@mlange05
Copy link
Collaborator

mlange05 commented Jul 3, 2023

Ok, overriding the codecov issue for now, as this hotfix is crucial. Merging now... :shipit:

@mlange05 mlange05 merged commit 615fdc5 into main Jul 3, 2023
@mlange05 mlange05 deleted the nabr-hotfix-pydantic branch July 3, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants