ECPhys: Add a "kernel-only" option to remove calls #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/111/index.html |
mlange05
force-pushed
the
naml-remove-call-kernel-only
branch
from
5559e11
to
d0b6b7b
Compare
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 92.14% 92.15%
=======================================
Files 89 89
Lines 16484 16486 +2
=======================================
+ Hits 15190 15192 +2
Misses 1294 1294
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This avoids the removal of DrHook calls in the driver layer, which we actually want for benchmarking.
mlange05
force-pushed
the
naml-remove-call-kernel-only
branch
from
d0b6b7b
to
741007e
Compare
reuterbal
approved these changes
Jul 3, 2023
| @@ -104,15 +104,22 @@ class RemoveCallsTransformation(Transformation): | |||
| Option to extend searches to :any:`Intrinsic` nodes to | |||
| capture print/write statements | |||
There was a problem hiding this comment.
Maybe worth adding here in the parameters list in the docstring.
awnawab
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the removal of DrHook calls in the driver layer, which we actually want for benchmarking.