-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ecwam regression tests to use develop branch #335
Conversation
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/335/index.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 170 171 +1
Lines 36467 36548 +81
=======================================
+ Hits 34759 34837 +78
- Misses 1708 1711 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
111a88b
to
1a6baca
Compare
32d22b3
to
172bee8
Compare
172bee8
to
8945845
Compare
Fix DEV_ALLOC_SIZE for ecwam regression and add SCC-HOIST variant
Thanks to @awnawab this should be ready now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and indeed many thanks for figuring out all the nifty details @reuterbal and @awnawab . I left one small comment on the use of the default arch (is this intentional and safe?), but if someone can confirm that this is fine, we're GTG. 👍
|
||
- name: Run CLOUDSC and ECWAM regression tests | ||
env: | ||
CLOUDSC_DIR: ${{ github.workspace }}/cloudsc | ||
CLOUDSC_ARCH: ${{ github.workspace }}/cloudsc/arch/github/ubuntu/gnu/9.4.0 | ||
ECWAM_DIR: ${{ github.workspace }}/ecwam | ||
ECWAM_ARCH: ${{ github.workspace }}/ecwam/arch/github/ubuntu/gnu/9.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double-checking: Is relying on default arch safe here? @awnawab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that implies no arch files are used, i.e., no specific toolchain.cmake and env.sh. Since none are required, this should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly, the ecwam CI also runs without any arch files and just relies on the default cmake/ecbuild flags plus those set by ecwam_compile_flags.cmake
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this, apologies for not wrapping this up sooner myself, it was long overdue. I can now finally forget about that very old ecwam dev branch that we were previously using 😄
No description provided.