Fix DEV_ALLOC_SIZE for ecwam regression and add SCC-HOIST variant #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/351/index.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 95.31% 95.32%
=======================================
Files 170 171 +1
Lines 36467 36548 +81
=======================================
+ Hits 34759 34838 +79
- Misses 1708 1710 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
awnawab
force-pushed
the
naan-nabr-update-ecwam-regression
branch
10 times, most recently
from
2ca0706
to
51cbca5
Compare
awnawab
force-pushed
the
naan-nabr-update-ecwam-regression
branch
from
51cbca5
to
6f8e8cb
Compare
reuterbal
changed the title
reuterbal
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small changes to fix the ecwam regression tests. What was causing the runtime failures was the default
DEV_ALLOC_SIZEin the FIELD_API buddy allocator. The change to the fypp+pyyaml installation is for a future ecwam update which relies on (in the absence of fckit) the system python installation having fypp+pyyaml.