Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecWAM regression tests: switch to develop-1.3 branch #358

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

awnawab
Copy link
Contributor

@awnawab awnawab commented Aug 9, 2024

Technical development in ecWAM will (at least for the short term) lag one cycle behind the latest scientific version. Therefore it makes more sense to run the loki regression tests on develop-1.3 which will be the staging branch for further technical developments on top of 49r1 science.

@awnawab awnawab requested a review from mlange05 August 9, 2024 06:24
Copy link

github-actions bot commented Aug 9, 2024

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/358/index.html

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (abf7968) to head (69a8cae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         173      173           
  Lines       36902    36902           
=======================================
  Hits        35191    35191           
  Misses       1711     1711           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as discussed offline, makes sense. GTG :shipit:

@mlange05 mlange05 added the ready for merge This PR has been approved and is ready to be merged label Aug 12, 2024
@mlange05 mlange05 merged commit a0dade4 into main Aug 13, 2024
13 checks passed
@mlange05 mlange05 deleted the naan-ecwam-regr branch August 13, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants