Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for 'resolve_vector_notation' utility #361

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

MichaelSt98
Copy link
Collaborator

problem occurred whenever two dimensions had the same size

e.g.,

integer :: ret1(param1, param1)
...
ret1(:, :) = 0

resulted in:

  DO i_ret1_1=1,param1
    DO i_ret1_0=1,param1
      ret1(i_ret1_1, i_ret1_1) = 0
    END DO
  END DO

instead of the correct result:

  DO i_ret1_1=1,param1
    DO i_ret1_0=1,param1
      ret1(i_ret1_0, i_ret1_1) = 0
    END DO
  END DO

Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/361/index.html

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.38%. Comparing base (cb2d5d5) to head (4f08967).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files         175      175           
  Lines       37039    37065   +26     
=======================================
+ Hits        35330    35356   +26     
  Misses       1709     1709           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! What an annoying little oversight... Fix looks great, good to go from me!

@reuterbal reuterbal added the ready for merge This PR has been approved and is ready to be merged label Aug 22, 2024
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Good catch, clean fix, neat test. GTG from me. :shipit:

@reuterbal reuterbal merged commit 49795ea into main Aug 23, 2024
13 checks passed
@reuterbal reuterbal deleted the nams-resolve-vector-notation-fix branch August 23, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants