Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki-transform: Pass cuf option to FilewriteTrafo #364

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

mlange05
Copy link
Collaborator

This is a small workaround for enabling SCC-CUF pipelines from config file in CLOUDSC. As we still push static config info alongside dynamic build system settings, this is needed for now if we don't want to preprocess the loki config via cmake.

Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/364/index.html

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Will merge as soon as CI is complete

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (68cb274) to head (1bf38b3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         178      178           
  Lines       37267    37267           
=======================================
  Hits        35555    35555           
  Misses       1712     1712           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuterbal reuterbal merged commit 1f87624 into main Aug 26, 2024
13 checks passed
@reuterbal reuterbal deleted the naml-loki-transform-filewrite-cuf branch August 26, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants