Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility to remove duplicate arguments for calls and callees #367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MichaelSt98
Copy link
Collaborator

Transform/convert e.g.,

 SUBROUTINE driver (nlon, nlev, nb, var)
  USE kernel_mod, ONLY: kernel
  IMPLICIT NONE
  INTEGER, INTENT(IN) :: nlon, nlev, nb
  REAL, INTENT(INOUT) :: var(nlon, nlev, 5, nb)
  INTEGER :: ibl
  INTEGER :: offset
  INTEGER :: some_val
  INTEGER :: loop_start, loop_end
  loop_start = 2
  loop_end = nb
  some_val = 0
  offset = 1
!$omp test
  DO ibl=loop_start,loop_end
    CALL kernel(nlon, nlev, var(:, :, 1, ibl), var(:, :, 1, ibl), var(:, :, 2:5, ibl), offset, loop_start, loop_end, nlev)
    CALL kernel(nlon, nlev, var(:, :, 1, ibl), var(:, :, 1, ibl), var(:, :, 2:5, ibl), offset, loop_start, loop_end, nlev)
  END DO
END SUBROUTINE driver
SUBROUTINE kernel (nlon, nlev, var1, var2, another_var, icend, lstart, lend, kend)
  USE compute_mod, ONLY: compute
  IMPLICIT NONE
  INTEGER, INTENT(IN) :: nlon, nlev, icend, lstart, lend, kend
  REAL, INTENT(INOUT) :: var1(nlon, nlev)
  REAL, INTENT(INOUT) :: var2(nlon, nlev)
  REAL, INTENT(INOUT) :: another_var(nlon, nlev, 4)
  INTEGER :: jk, jl, jt
  var1(:, :) = 0.
  DO jk=1,kend
    DO jl=1,nlon
      var1(jl, jk) = 0.
      var2(jl, jk) = 1.0
      DO jt=1,4
        another_var(jl, jk, jt) = 0.0
      END DO
    END DO
  END DO
  CALL compute(nlon, nlev, var1, var2)
  CALL compute(nlon, nlev, var1, var2)
END SUBROUTINE kernel
SUBROUTINE compute (nlon, nlev, b_var, a_var)
  IMPLICIT NONE
  INTEGER, INTENT(IN) :: nlon, nlev
  REAL, INTENT(INOUT) :: b_var(nlon, nlev)
  REAL, INTENT(INOUT) :: a_var(nlon, nlev)
  b_var(:, :) = 0.
  a_var(:, :) = 1.0
END SUBROUTINE compute

to

SUBROUTINE driver (nlon, nlev, nb, var)
  USE kernel_mod, ONLY: kernel
  IMPLICIT NONE
  INTEGER, INTENT(IN) :: nlon, nlev, nb
  REAL, INTENT(INOUT) :: var(nlon, nlev, 5, nb)
  INTEGER :: ibl
  INTEGER :: offset
  INTEGER :: some_val
  INTEGER :: loop_start, loop_end
  loop_start = 2
  loop_end = nb
  some_val = 0
  offset = 1
!$omp test
  DO ibl=loop_start,loop_end
    CALL kernel(nlon, nlev, var(:, :, 1, ibl), var(:, :, 2:5, ibl), offset, loop_start, loop_end)
    CALL kernel(nlon, nlev, var(:, :, 1, ibl), var(:, :, 2:5, ibl), offset, loop_start, loop_end)
  END DO
END SUBROUTINE driver
SUBROUTINE kernel (nlon, nlev, var, another_var, icend, lstart, lend)
  USE compute_mod, ONLY: compute
  IMPLICIT NONE
  INTEGER, INTENT(IN) :: nlon, nlev, icend, lstart, lend
  REAL, INTENT(INOUT) :: var(nlon, nlev)
  REAL, INTENT(INOUT) :: another_var(nlon, nlev, 4)
  INTEGER :: jk, jl, jt
  var(:, :) = 0.
  DO jk=1,nlev
    DO jl=1,nlon
      var(jl, jk) = 0.
      var(jl, jk) = 1.0
      DO jt=1,4
        another_var(jl, jk, jt) = 0.0
      END DO
    END DO
  END DO
  CALL compute(nlon, nlev, var)
  CALL compute(nlon, nlev, var)
END SUBROUTINE kernel
SUBROUTINE compute (nlon, nlev, var)
  IMPLICIT NONE
  INTEGER, INTENT(IN) :: nlon, nlev
  REAL, INTENT(INOUT) :: var(nlon, nlev)
  var(:, :) = 0.
  var(:, :) = 1.0
END SUBROUTINE compute

Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/367/index.html

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 99.22481% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.41%. Comparing base (1f87624) to head (40fda0b).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
loki/transformations/utilities.py 98.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   95.40%   95.41%   +0.01%     
==========================================
  Files         178      178              
  Lines       37267    37394     +127     
==========================================
+ Hits        35555    35681     +126     
- Misses       1712     1713       +1     
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.40% <99.22%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant