Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add qos_tags and functions factory #76

Merged
merged 6 commits into from
Aug 30, 2023
Merged

add qos_tags and functions factory #76

merged 6 commits into from
Aug 30, 2023

Conversation

francesconazzaro
Copy link
Collaborator

No description provided.

gbiavati
gbiavati reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@gbiavati gbiavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would not harm to see an example of usage for any qos function implemented (in readme or a sample qos rule file as reference)

@francesconazzaro
Copy link
Collaborator Author

@gbiavati I've added a section to the README

gbiavati
gbiavati approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@gbiavati gbiavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the helpful example

@francesconazzaro francesconazzaro changed the title [WIP] add qos_tags and functions factory add qos_tags and functions factory Aug 30, 2023
@francesconazzaro
Copy link
Collaborator Author

@gbiavati @EddyCMWF @b8raoult
I had to add the support for lists. The lists can be used with ( and ).

@francesconazzaro francesconazzaro merged commit 2b2746e into main Aug 30, 2023
6 of 8 checks passed
@francesconazzaro francesconazzaro deleted the add-qos_tags-and-functions-factory branch August 30, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiavati gbiavati gbiavati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francesconazzaro @gbiavati