Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Area graphs #30

Merged
merged 168 commits into from
Oct 3, 2024
Merged

Local Area graphs #30

merged 168 commits into from
Oct 3, 2024

Conversation

JPXKQX
Copy link
Member

@JPXKQX JPXKQX commented Aug 9, 2024

This PR implements the functionality to build graphs only in an area of interest (AOI).

This includes:

  • A new node builder, CutOutZarrDatasetNodes, which allows to create nodes from 2 zarr datasets using cutout operation from anemoi-datasets.
  • A new class, KNNAreaMaskBuilder, to specify an AOI based on a set of nodes, for which we can specify node attributes to mask the nodes of interest.
  • A new set of node builders, LimitedArea...Nodes, which allows the creation of the nodes only within an Area Of Interest (AOI).
  • Expanding the MultiScaleEdges functionalities to support multi-scale connections in limited area graphs.

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation and docstrings to reflect the changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have ensured that the code is still pip-installable after the changes and runs
  • I have ran this on single GPU
  • I have ran this on multi-GPU or multi-node

Issue ticket number and link

Issues #7

This work would not have been possible without @theissenhelen and @JesperDramsch and the rest of the AIFS team!


📚 Documentation preview 📚: https://anemoi-graphs--30.org.readthedocs.build/en/30/

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@mchantry mchantry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Haven't run the tests yet.

@ecmwf ecmwf deleted a comment from FussyDuck Sep 12, 2024
mchantry
mchantry previously approved these changes Sep 22, 2024
Copy link
Member

@mchantry mchantry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work all involved.

Copy link
Member

@mchantry mchantry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@JPXKQX JPXKQX merged commit 986ee9e into develop Oct 3, 2024
114 checks passed
@JPXKQX JPXKQX deleted the 7-local-area-modelling-graphs branch October 3, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ATS approved enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Area Modelling - Graphs
4 participants