Feature/adding dart support

[stefaniereuter]

This is related to ECC-1922 , to add support for Fesom grid DART . This is relevant for intermediate climate DT runs with FESOM.

[FussyDuck]

All committers have signed the CLA.

[stefaniereuter]

I initially thought that C and N stands for Core2 and NG5 in subgridType but I then found a comment from Willem that it actually stands for centroids and edges i.e. the second commit that removes the D

[shahramn]

@stefaniereuter You need to sign the CLA (Contributor License Agreement) before we can proceed.
Vielen Dank

[dsarmany]

I initially thought that C and N stands for Core2 and NG5 in subgridType but I then found a comment from Willem that it actually stands for centroids and edges i.e. the second commit that removes the D

Yes, that is correct. So the combined changes in this PR are fine. It will be probably be worth squashing them into a single commit at the point of merging it.

[stefaniereuter]

Hi Sharam, sorry I had already signed it but I did not click on rechecking. For me it now says all committers signed... So I assume it worked

[shahramn]

The last three entries in this table should be prefixed by a string like FESOM
e.g.,

'FESOM_CORE2' = { numberOfGridUsed = 8; }
'FESOM_NG5'   = { numberOfGridUsed = 9; }
'FESOM_DART' =  { numberOfGridUsed = 10; }

Note how the other names have the ORCA substring.

Really this kind of naming should be the responsibility of Data Governance

[stefaniereuter]

I've just contacted Data Governance. I'll create a ticket in their jira space and will let you know what they say.

[mjg41]

Hi,
From discussions with @wdeconinck and his confluence page that you linked above, all those new ocean grids are handcrafted for the FESOM ocean model by the AWI developers. Therefore I'd be happy with leaving them as they are with no additional changes to be honest. Ultimately this is only a concept helper key which is in our local definitions in any case, and the number is the key fixed piece of metadata.
So now DGOV approved, thanks for bringing it to our attention!

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.81%. Comparing base (344d9ef) to head (f917841).
Report is 12 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #246   +/-   ##
========================================
  Coverage    87.81%   87.81%           
========================================
  Files          776      776           
  Lines        62512    62512           
  Branches     11035    11035           
========================================
  Hits         54892    54892           
  Misses        7620     7620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shahramn]

We have a metkit test failure (metkit_test_codes_decoder). The test expects the value of "unknown" for unstructuredGridType.
I have asked @danovaro to fix it. Once that is done, I will merge this PR