Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define uint64_t type grib_en/decode and use them #62

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mtasaka
Copy link
Contributor

@mtasaka mtasaka commented Jan 10, 2022

Currently grib_encode_size_t / grib_decode_size_t are defined and
especially on windows where size_t is 64 bit,
encode_double_array and decode_double_array use them.

So especially for 32 bit linux system, define uint64_t type grib_encode /
grib_decode and use them instead of size_t type ones. This method is
more portable.

The proposal patch fixes the following test failure on Linux 32 bit:

#  35 - eccodes_t_bufr_ecc-1290

Forwarded from: https://jira.ecmwf.int/browse/SUP-3561

Currently grib_encode_size_t / grib_decode_size_t are defined and
especially on windows where size_t is 64 bit,
encode_double_array and decode_double_array use them.

So especially for 32 bit linux system, define uint64_t type grib_encode /
grib_decode and use them instead of size_t type ones. This method is
more portable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant