Feature list depth option #34

mcakircali · 2024-08-08T08:44:18Z

No description provided.

from Simon branch

implements ctor for 1-,2-,3-level split key chains [skip-ci]

cleanup and add missing

reworked it to behave more like an iterator

codecov-commenter · 2024-08-08T08:49:48Z

Codecov Report

Attention: Patch coverage is 79.92565% with 54 lines in your changes missing coverage. Please review.

Project coverage is 64.10%. Comparing base (7f8e64c) to head (5aca515).

Files with missing lines	Patch %	Lines
src/fdb5/api/helpers/ListElement.cc	48.21%	29 Missing ⚠️
src/fdb5/tools/fdb-list.cc	67.56%	12 Missing ⚠️
src/fdb5/api/RemoteFDB.cc	0.00%	6 Missing ⚠️
src/fdb5/database/KeyChain.h	85.00%	3 Missing ⚠️
src/fdb5/remote/Handler.cc	0.00%	2 Missing ⚠️
src/fdb5/api/helpers/ListElement.h	75.00%	1 Missing ⚠️
src/fdb5/tools/fdb-patch.cc	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop      #34      +/-   ##
===========================================
+ Coverage    63.84%   64.10%   +0.26%     
===========================================
  Files          237      239       +2     
  Lines        13583    13675      +92     
  Branches      1325     1330       +5     
===========================================
+ Hits          8672     8767      +95     
+ Misses        4911     4908       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/fdb5/api/helpers/ListElement.cc

src/fdb5/api/helpers/ListElement.h

src/fdb5/tools/fdb-list.cc

tests/fdb/api/test_fdb_c.cc

src/fdb5/api/local/ListVisitor.h

introduces

only datum elements support location

and several minor issues

mcakircali added 30 commits August 8, 2024 09:51

test(toKey): add check step value

862778c

feat(list): cherry-pick level

d60aeb8

from Simon branch

test(fdb-list): add new

d23778c

test(fdb-list): prepare grib file

3be1f22

fix(fdb-list): init class member

e0a0421

fix(fdb-list): unnecessary copy in loop

c2703ab

fix(fdb-list): use make_unique not "new"

36e6a54

fix(fdb-list): use "override" (not virtual)

77e3d77

fix(fdb-list): default member init and tab size

1e3381b

test(fdb-list): added --depth option

7f6be88

fix(ListVisitor): empty keys

5dfb6a0

style(fdb-list): clean code

71bbf51

fix(fdb-list): porcelain defaults other options

c4ebc5b

chore(remote/Handler): todo list w/ level

8ce657e

feat(list)!: separate ListElement

8d9db4e

implements ctor for 1-,2-,3-level split key chains [skip-ci]

fix(ListVisitor): use discrete ListElement ctor for DB, Cat, and Datum

fb4b8a0

fix(FDB): missing include

2c2b79d

fix(FDB): name collisions

31edc16

fix(FDB): unnecessary copy in loop

376d842

fix(FDB): after new ListElement

4a81dad

fix(FDB): 'some' include issues

e5edc6c

cleanup and add missing

chore(c api): param should be sha1

81a3924

fix(c api): splitkey iterator

6d67ae6

reworked it to behave more like an iterator

fix(fdb-patch): after ListElement

b68231b

fix(fdb-list): includes

a0cb5fa

feat(fdb-list): options; assert depth and porcelain text

dbf974e

fix(fdb-list): keys api

4595fa7

fix(FieldLocation): remove nullLocation

7c42889

fix(MultiRetrieveVisitor): include issues

f41ca4d

feat(remote): added level to Handler

70768b9

mcakircali added 2 commits August 8, 2024 09:51

fix(c api): guard offset/len < 0

f1cc638

fix(fdb-list): updated doc for depth option

24b70de

mcakircali requested a review from simondsmart August 8, 2024 08:44

mcakircali marked this pull request as ready for review August 8, 2024 08:57

mcakircali added 2 commits August 9, 2024 13:10

test(fdb-list): rename cf -> an

39b27cd

test(fdb-list): moved it to its own directory

d8c3ec2

simondsmart requested changes Aug 13, 2024

View reviewed changes

mcakircali added 13 commits August 13, 2024 16:52

fix(c api): revert fdb_splitkey_t API

38c24d3

fix(c api): make fdb_splitkey_t work

12b398f

introduces

fix(c api): removed junk find()

8cd9711

style(c api): typo

376d511

feat(ListElement): throw with a msg

de79888

only datum elements support location

feat(ListElement): added KeyChain (aka SplitKey)

59fdb36

style: preserve api

8e209ea

style: replace auto

bea681d

fix(fdb-list): param defaults and throw for porcelain option

7e73116

Merge branch 'develop' into feature/list-depth-option

05890a3

fix(c api): fdb_list assert bug

346a47f

fix(ListElement): offset/length returns 0 for non-datum elements

7f72cc3

test(c api): added fdb_list with depth=1,2,3

14d0f74

mcakircali requested a review from simondsmart August 14, 2024 13:38

mcakircali added 8 commits August 14, 2024 18:31

fix(ListElement): bug print length

cbef3e9

fix(ListElement): api issues around FieldLocation shared_ptr

75bcf1c

docs(fdb-list): corrected depth range

d638c98

test(fdb-list): rename cf -> an

25e03d1

test(fdb-list): add marsflow tests

d82131f

test(fdb-list): fix macos grep issue

13eeff9

and several minor issues

test(fdb-list): cleanup after success

bf03921

Merge branch 'develop' into feature/list-depth-option

5aca515

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature list depth option #34

Feature list depth option #34

mcakircali commented Aug 8, 2024

codecov-commenter commented Aug 8, 2024 •

edited

Loading

Feature list depth option #34

Are you sure you want to change the base?

Feature list depth option #34

Conversation

mcakircali commented Aug 8, 2024

codecov-commenter commented Aug 8, 2024 • edited Loading

Codecov Report

codecov-commenter commented Aug 8, 2024 •

edited

Loading