Verrsion bump restore 11.0.0 with CI fix #875
Merged
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .circleci/config.yml
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
d4r1091
added a commit
that referenced
this pull request
Mar 19, 2025
d4r1091
added a commit
that referenced
this pull request
Mar 19, 2025
d4r1091
added a commit
that referenced
this pull request
Mar 19, 2025
d4r1091
added a commit
that referenced
this pull request
Mar 19, 2025
d4r1091
added a commit
that referenced
this pull request
Mar 19, 2025
And addition added later via force push to fix the project path + Common.xcconfig path
d4r1091
added a commit
that referenced
this pull request
Mar 19, 2025
And addition added later via force push to fix the project path + Common.xcconfig path as well as some build settings fixes.
d4r1091
added a commit
that referenced
this pull request
Mar 19, 2025
And addition added later via force push to fix the project path + Common.xcconfig path as well as some build settings fixes.
d4r1091
added a commit
that referenced
this pull request
Mar 19, 2025
And addition added later via force push to fix the project path + Common.xcconfig path as well as some build settings fixes.
d4r1091
added a commit
that referenced
this pull request
Mar 20, 2025
And addition added later via force push to fix the project path + Common.xcconfig path as well as some build settings fixes. Also referencing the empty Production file to make it editable.
d4r1091
pushed a commit
that referenced
this pull request
Mar 22, 2025
Some additions are added on top of the referenced PR in the commit. This is a force-pushed commit to keep the latest version bump to 11.0.0 ------ Added the possibility to strictly reference to `main` and `main-xxx` branches to spin up builds. Major fixes are inherent to the `firefox-ios` path added to the `check_marketing_version.sh` script as well as some `yml` CI files for both GitHub Actions and CircleCI. We are also referencing an empty Production file (git ignored) to make easy for the CI script to inject the required production-only configs.
d4r1091
pushed a commit
that referenced
this pull request
Mar 22, 2025
Some additions are added on top of the referenced PR in the commit. This is a force-pushed commit to keep the latest version bump to 11.0.0 ------ Added the possibility to strictly reference to `main` and `main-xxx` branches to spin up builds. Major fixes are inherent to the `firefox-ios` path added to the `check_marketing_version.sh` script as well as some `yml` CI files for both GitHub Actions and CircleCI. We are also referencing an empty Production file (git ignored) to make easy for the CI script to inject the required production-only configs.
d4r1091
added a commit
that referenced
this pull request
Mar 24, 2025
And addition added later via force push to fix the project path + Common.xcconfig path as well as some build settings fixes. Also referencing the empty Production file to make it editable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I'm restoring the version Bump here and applying the Fix that triggers the CI to check the
Common.xcconfigpath correctly.I'm also adding the check on our CI to be able to trigger a release out of our
main-[old-firefox-vanilla-ref]branch.