Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use scram implementation from edgedb-js + polish login page design #405

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

jaclarke
Copy link
Member

@jaclarke jaclarke commented Feb 5, 2025

Fixes #404

image

@scotttrinh @beerose Want to do a quick pass over the copy, or does it look ok?

@scotttrinh
Copy link
Contributor

My only feedback would be to either be more emphatic about suggesting gel ui or give more reason why. As it is, it seems like just a passing comment.

@jaclarke
Copy link
Member Author

jaclarke commented Feb 5, 2025

Yeah, I wasn't sure about putting too much emphasis on that message, as it's just guessing based on the server url and meant to help users that somehow end up on the login page (you should never see this page if you're using gel ui), so it could be wrong if you're running the server in docker or something. Maybe just saying that would resolve the issue, so something like 'It looks like you're running Gel locally. If you created the instance using the Gel CLI, the easiest way to login is by running the gel ui command from your project directory'?

@jaclarke
Copy link
Member Author

jaclarke commented Feb 6, 2025

image

@jaclarke jaclarke merged commit 635e907 into main Feb 6, 2025
2 checks passed
@jaclarke jaclarke deleted the fix-login-page branch February 6, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login UI - ReferenceError: Buffer is not defined
2 participants