-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
peer-pods: pass policy hash via userdata #941
Open
burgerdev
wants to merge
1
commit into
main
Choose a base branch
from
burgerdev/user-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
burgerdev
commented
Oct 18, 2024
- Add some plumbing to forward the agent policy to remote hypervisor
- Add a policy-hash field to the agent config that's set via userdata.
- Measure the agent config into PCR10.
- The daemon config contains a bunch of hard-to-predict network config, but we should double-check whether it could be an attack vector.
- Add hash-from-agent-config as an option in the hash-verification.
burgerdev
force-pushed
the
burgerdev/user-data
branch
2 times, most recently
from
October 18, 2024 11:36
aeacb19
to
d6dd9c1
Compare
Freax13
reviewed
Oct 18, 2024
packages/by-name/cloud-api-adaptor/0001-measure-agent-config.toml-into-PCR-10.patch
Outdated
Show resolved
Hide resolved
packages/by-name/cloud-api-adaptor/0001-measure-agent-config.toml-into-PCR-10.patch
Outdated
Show resolved
Hide resolved
burgerdev
force-pushed
the
burgerdev/user-data
branch
from
October 24, 2024 15:23
d6dd9c1
to
ffee8e8
Compare
I tested this (with runtime binaries and CAA container image manually replaced) and got a pod that verifies the policy and measures PCR10 as expected. |
Freax13
approved these changes
Oct 25, 2024
burgerdev
force-pushed
the
burgerdev/user-data
branch
from
November 4, 2024 21:54
ffee8e8
to
d1f1edf
Compare
burgerdev
force-pushed
the
burgerdev/clean-patches
branch
2 times, most recently
from
November 5, 2024 09:44
d11aa21
to
3d721ad
Compare
burgerdev
force-pushed
the
burgerdev/user-data
branch
from
November 5, 2024 10:38
d1f1edf
to
61d83c4
Compare
Freax13
approved these changes
Nov 6, 2024
Thanks for the re-review! I'm holding this PR back until we have a working peerpods setup on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.