wip: basic test for peerpods #990
Draft
+131
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
force-pushed
the
burgerdev/pp-test
branch
2 times, most recently
from
f06eefc
to
b8abf02
Compare
burgerdev
commented
Nov 13, 2024
Comment on lines
+27
to
+28
| export azure_resource_group=contrast-ci | ||
| export azure_location=germanywestcentral |
There was a problem hiding this comment.
Should these values come from repository vars?
| @@ -201,7 +200,7 @@ create platform=default_platform: | |||
| echo "subscription_id = \"$azure_subscription_id\"" >> infra/azure-peerpods/just.auto.tfvars | |||
|
|
|||
| nix run -L .#terraform -- -chdir=infra/azure-peerpods init | |||
| nix run -L .#terraform -- -chdir=infra/azure-peerpods apply | |||
| nix run -L .#terraform -- -chdir=infra/azure-peerpods apply --auto-approve | |||
Comment on lines
+8
to
+13
| true || nix run -L .#scripts.upload-image -- \ | ||
| --subscription-id="${azure_subscription_id:?}" \ | ||
| --location="${azure_location:?}" \ | ||
| --resource-group="${azure_resource_group:?}" | ||
| image_id=/subscriptions/0d202bbb-4fa7-4af8-8125-58c269a05435/resourceGroups/contrast-ci/providers/Microsoft.Compute/galleries/contrast_ci_contrast/images/contrast/versions/0.0.1730981348 | ||
| echo "image_id = \"${image_id}\"" > infra/azure-peerpods/image_id.auto.tfvars |
There was a problem hiding this comment.
Make building the image optional by allowing an override input image id.
Comment on lines
+19
to
+21
| tenant_id = "${azure_tenant_id:?}" | ||
| client_id = "${azure_client_id:?}" | ||
| client_secret = "${azure_client_secret:?}" |
There was a problem hiding this comment.
Should these be justfile.env vars?
burgerdev
force-pushed
the
burgerdev/pp-test
branch
from
e9dcaf9
to
0aa7546
Compare
burgerdev
commented
Nov 13, 2024
| echo "image_id = \"${image_id}\"" > infra/azure-peerpods/image_id.auto.tfvars | ||
|
|
||
| cat >infra/azure-peerpods/testrun.auto.tfvars <<EOF | ||
| name_prefix = "${azure_resource_group:?}" |
There was a problem hiding this comment.
This should be randomized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.