Repository navigation
Conversation
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previously server.py had many things to care, it had to handle web requests and also at the same time it had to responsible for:
As the issue #243 explains, the crash recovery logic was tangled inside the HTTP request handler. The pool state was also stored loosely in Tornado's settings dictionary instead of a proper separated object. This made it hard to understand and test independently from the web serving code.
So I extracted all process pool logic into a new class DiffExecutorManager in a new file executor.py.
executor.py now owns:
server.py is now only responsible for:
Because of this change, if the ProcessPoolExecutor crashes, the web server keeps running normally. Only the worker pool gets recycled inside DiffExecutorManager and the HTTP server and request handling in server.py are completely safe and unaffected.
Close issue(#243)
@Mr0grog