Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stub with undefined #56

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Fix stub with undefined #56

merged 2 commits into from
Sep 3, 2023

Conversation

edgurgel
Copy link
Owner

Fixes #54

escobera
escobera approved these changes Aug 31, 2023
View reviewed changes
Copy link

@escobera escobera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apreifsteck
apreifsteck approved these changes Sep 2, 2023
View reviewed changes
Copy link

@apreifsteck apreifsteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer of course, but for what it's worth, it looks good to me! Thank you for addressing this issue!

@edgurgel edgurgel merged commit 39d8665 into main Sep 3, 2023
6 checks passed
@edgurgel edgurgel deleted the fix-stub-with-undefined branch September 3, 2023 08:39
@edgurgel
Copy link
Owner Author

edgurgel commented Sep 3, 2023

Thanks, team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escobera escobera escobera approved these changes

@apreifsteck apreifsteck apreifsteck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling stub_with/2 with a second module that doesn't exist causes Mimic to fail in unpredictable ways
3 participants
@edgurgel @escobera @apreifsteck