Skip to content

Make the whole box clickable in read-only mode #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Make the whole box clickable in read-only mode #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ed3e6e2
Make the whole box clickable in read-only mode
bettysteger Oct 7, 2025
1180873
Merge branch 'master' into boxclick
bettysteger Oct 7, 2025
352c704
bump patch version
bettysteger Oct 7, 2025
9c8d918
Merge branch 'editor-js:master' into boxclick
bettysteger Oct 9, 2025
9a7c851
Merge branch 'master' into boxclick
bettysteger Oct 16, 2025
cdb07f7
bump version
bettysteger Oct 16, 2025
db16ffd
Merge branch 'editor-js:master' into boxclick
bettysteger Oct 16, 2025
db3c16b
refactor Make the whole box clickable with a-tag
bettysteger Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@editorjs/attaches",
"version": "1.3.2",
"version": "1.3.3",
"keywords": [
"codex editor",
"attaches",
Expand Down
6 changes: 6 additions & 0 deletions src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.cdx-attaches {
--color-line: #EFF0F1;
--color-line--hover: #e7e8e9;
--color-bg: #fff;
--color-bg-secondary: #F8F8F8;
--color-bg-secondary--hover: #f2f2f2;
Expand All @@ -12,6 +13,11 @@
border: 1px solid var(--color-line);
border-radius: 7px;
background: var(--color-bg);
text-decoration: none !important;
Copy link
Contributor Author

@bettysteger bettysteger Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need the !important because .ce-block a has text-decoration style


&[href]:hover, &[href]:focus {
--color-line: var(--color-line--hover);
}

^&__file-info {
display: grid;
Expand Down
6 changes: 4 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,9 @@ export default class AttachesTool {
render() {
const holder = make('div', this.CSS.baseClass);

this.nodes.wrapper = make('div', this.CSS.wrapper);
// Make the whole box clickable in read-only mode
this.nodes.wrapper = make(this.readOnly ? 'a' : 'div', this.CSS.wrapper,
this.readOnly ? { href: this.data.file.url, target: '_blank' } : {});

if (this.pluginHasData()) {
this.showFileData();
Expand Down Expand Up @@ -437,7 +439,7 @@ export default class AttachesTool {
this.nodes.wrapper.appendChild(fileInfo);

if (file.url !== undefined) {
const downloadIcon = make('a', this.CSS.downloadButton, {
const downloadIcon = make(this.readOnly ? 'span' : 'a', this.CSS.downloadButton, {
innerHTML: IconChevronDown,
href: file.url,
target: '_blank',
Expand Down