Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (road to typescript): migrate from javascript to typescript #252

Merged
merged 13 commits into from
Jul 8, 2024
Merged

feat (road to typescript): migrate from javascript to typescript #252

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
65969bb
feat (road to typescript): migrate from javascript to typescript
dependentmadani Jun 18, 2024
76ff281
update (fix the issues): changes after the review
dependentmadani Jun 18, 2024
b85e432
refactor (multiple modification): Refactore image tool UI and upload…
dependentmadani Jun 19, 2024
e071d6a
refactor: few modification from last review
dependentmadani Jun 19, 2024
7edd811
refactor: fix multiple issues
dependentmadani Jun 19, 2024
c51ca26
fix (few modification): modification reviews by neSpecc
dependentmadani Jun 23, 2024
e21fece
update (in different files): fix the issues thanks to the reviews
dependentmadani Jun 27, 2024
e79366d
update(last review): modifications based on last review
dependentmadani Jul 4, 2024
c8c21c3
fix(icons): remove manual declaration of icons types
dependentmadani Jul 4, 2024
a5f7ad1
update(reviewed): fix minor possible issues thanks to the reviews pro…
dependentmadani Jul 5, 2024
d265261
update(interfaces): possbile additional data in file object an ImageT…
dependentmadani Jul 6, 2024
1a12e9a
update: use generic types instead of Record
dependentmadani Jul 6, 2024
dc750a5
update(naming): change the naming of a generic type
dependentmadani Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
{
"extends": [
"codex"
],
"globals": {
"fetch": true,
"ImageConfig": true,
"ImageToolData": true
}
}
"HTMLOListElement": true,
"HTMLUListElement": true
neSpecc marked this conversation as resolved.
Show resolved Hide resolved
},
"parserOptions": {
"sourceType": "module",
"ecmaVersion": 2020
},
"parser": "@typescript-eslint/parser"
}
13 changes: 13 additions & 0 deletions .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,19 @@ on:
- master

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 19
registry-url: https://registry.npmjs.org/
- run: yarn install
- run: yarn build
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
neSpecc marked this conversation as resolved.
Show resolved Hide resolved

publish-and-notify:
uses: codex-team/github-workflows/.github/workflows/npm-publish-and-notify-reusable.yml@main
secrets:
Expand Down
34 changes: 20 additions & 14 deletions package.json
View file
Open in desktop
dependentmadani marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@editorjs/image",
"version": "2.9.0",
"version": "2.9.1",
"keywords": [
"codex editor",
"image",
Expand All @@ -15,6 +15,7 @@
],
"main": "./dist/image.umd.js",
"module": "./dist/image.mjs",
"types": "dist/index.d.ts",
"exports": {
".": {
"import": "./dist/image.mjs",
neSpecc marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -24,27 +25,32 @@
"scripts": {
"dev": "vite",
"build": "vite build",
"lint": "eslint src/ --ext .js",
"lint:errors": "eslint src/ --ext .js --quiet",
"lint:fix": "eslint src/ --ext .js --fix"
"lint": "eslint src/ --ext .ts",
"lint:errors": "eslint src/ --quiet",
"lint:fix": "eslint src/ --fix"
},
"author": {
"name": "CodeX",
"email": "[email protected]"
},
"devDependencies": {
"@codexteam/ajax": "^4.2.0",
"eslint": "^6.8.0",
"eslint-config-codex": "^1.3.3",
"eslint-loader": "^4.0.0",
"formidable": "^1.2.1",
"postcss-nested": "^4.1.0",
"postcss-nested-ancestors": "^2.0.0",
"@editorjs/editorjs": "2.30.0-rc.12",
"@typescript-eslint/eslint-plugin": "^7.13.1",
"@typescript-eslint/parser": "^7.13.1",
"eslint": "^7.22.0",
"eslint-config-codex": "^2.0.1",
"eslint-loader": "^4.0.2",
"formidable": "^3.5.1",
"postcss-nested": "^6.0.1",
"postcss-nested-ancestors": "^3.0.0",
"request": "^2.88.0",
"vite": "^4.5.0",
"vite-plugin-css-injected-by-js": "^3.3.0"
"typescript": "^5.4.5",
"vite": "^5.3.1",
"vite-plugin-css-injected-by-js": "^3.5.1",
"vite-plugin-dts": "^3.9.1"
},
"dependencies": {
"@codexteam/icons": "^0.0.6"
"@codexteam/icons": "^0.3.0"
}
}
}
Loading
Loading