Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue 256): upload issue with images fix #257

Merged
merged 4 commits into from
Jul 17, 2024
Merged

fix(issue 256): upload issue with images fix #257

merged 4 commits into from
Jul 17, 2024

Conversation

dependentmadani
Copy link
Contributor

Problem

The issue #256 where the 'files' is used the upload request instead of images in default configuration.

Cause

The cause of this issue is when the field in the configuration is not defined by the user, for this reason, the 'files' is used by ajax.transport by default.

Solution

The solution for this issue is to use image value in config of ImageTool when it is not defined by the user.

dev/server.js Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
src/uploader.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update package json pls

src/uploader.ts Outdated Show resolved Hide resolved
@neSpecc neSpecc merged commit de05642 into master Jul 17, 2024
1 check passed
@neSpecc neSpecc deleted the fix-issue branch July 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants