fix(conform-react): support resolveSubmission on server - #1334
edmundhung wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 680b4f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (9)
🔇 Additional comments (4)
📝 WalkthroughWalkthroughThe PR moves ChangesSubmission resolution API
Priority: ⬇️ Low — Defer the server-side submission resolver change because it is a focused Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change makes submission resolution available through the server-safe intent API while preserving configured form handlers and existing resolution behavior. No concrete current-head merge risk remains. Sequence Diagram(s)sequenceDiagram
participant LoginAction
participant resolveSubmission
participant IntentHandlers
participant Validation
LoginAction->>resolveSubmission: resolve submission
resolveSubmission->>IntentHandlers: parse and resolve intent
IntentHandlers-->>resolveSubmission: return intent and targetValue
resolveSubmission-->>LoginAction: return resolved submission data
LoginAction->>Validation: validate targetValue or empty object
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit hops through forms so bright Comment |
Deploying conform with
|
| Latest commit: |
680b4f4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a69546a.conform.pages.dev |
| Branch Preview URL: | https://edmundhung-fix-resolve-submi.conform.pages.dev |
More templates
@conform-to/dom
@conform-to/react
@conform-to/valibot
@conform-to/validitystate
@conform-to/yup
@conform-to/zod
commit: |
1145714 to
1d094e3
Compare
1d094e3 to
680b4f4
Compare
Summary
intentmoduleconfigureFormsresolveSubmissioncoverage in both Node and browser test projectsFixes the issue reported in #954 (comment).
Verification
pnpm --filter @conform-to/react typecheckpnpm --filter @conform-to/react buildpnpm --filter @conform-to/react exec vitest --project 'conform-react (node)' --run --typecheck.enabled=falseGenerated Summary
createSubmissionResolverfor server-saferesolveSubmissionsupport.resolveSubmissionexports tointent.@conform-to/react.