Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema.ts #587

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Update schema.ts #587

merged 3 commits into from
Nov 14, 2024

Conversation

vra5107
Copy link
Contributor

@vra5107 vra5107 commented Nov 12, 2024

CodeQL is complaining about missing js regex anchors.

Misleading operator precedence. The subexpression '^true' is anchored at the beginning, but the other parts of this regular expression are not Misleading operator precedence. The subexpression 'false$' is anchored at the end, but the other parts of this regular expression are not

https://codeql.github.com/codeql-query-help/javascript/js-regex-missing-regexp-anchor/

@eemeli
Copy link
Owner

eemeli commented Nov 12, 2024

Huh, that is indeed a bug. Should probably add a test or two for this as well, probably around here. Would you be up to doing so?

@vra5107
Copy link
Contributor Author

vra5107 commented Nov 13, 2024

@eemeli I have added a test. Did run it locally and it does pass. It does return an error for something like ffalse and Truea. If you can kindly merge and release a new version, I will pull the latest version. Security is a mania these days.

@eemeli eemeli merged commit 108f699 into eemeli:main Nov 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants