Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore browser field when running with Fastboot #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore browser field when running with Fastboot #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/caching-browserify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ module.exports = CoreObject.extend({
packageCache: {},
fullPaths: this.fullPaths,
basedir: this._inputStaging,
debug: this.enableSourcemap
debug: this.enableSourcemap,
browserField: !process.env.EMBER_CLI_FASTBOOT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this mode isn't a thing anymore, we likely need to produce 2 bundles. One for fastboot and one without.

Slightly more involved, but will solve this nicely!

Copy link
Author

@gabrielgrant gabrielgrant Jun 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not sure I understand...which mode isn't a thing anymore?

...and sorry I haven't had a chance to get back to tracking down the original error I was seeing when I first implemented this, we pushed off our fastboot deploy :/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EMBER_CLI_FASTBOOT is not a thing in fastboot 1.0, there is only 1 build now, now two (fastboot + non-fastboot)

Copy link
Author

@gabrielgrant gabrielgrant Jul 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, interesting. Like I said, haven't been following development too closely of late. According to https://ember-fastboot.com/docs/user-guide#packaging-your-app there's still an app-fastboot.js asset generated at build time. I'm not sure I follow what ends up in that bundle, though. Is it just the fastbootDependencies defined in your app's package.json? Could this still be used somehow to override the browser version of a package with the non-browser build?

(or are you saying that doc is out of date, and that file actually no longer gets created?)

}, this.browserifyOptions);

var b = browserify(opts);
Expand Down