Remove default_nettype statements at the end of the RTL#366
Open
kareefardi wants to merge 1 commit intomainfrom
Open
Remove default_nettype statements at the end of the RTL#366kareefardi wants to merge 1 commit intomainfrom
kareefardi wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Contributor
|
I'm not sure if it a standard this but I recall to notice on compiler was dealing with the `default_nettype as a global macro not just for the current file. So if we removed the line in the end of the file, the next to be compiled will be treated as if the default net type is none. So, I don't recommend it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by The-OpenROAD-Project/OpenLane#2083. Yosys would use the
default nettype wirewhen compiling the user project. Although this might be an ambiguity in yosys behavior, I don't see the need of adding these lines. Having said that, there presence in the RTL seems to be intentional, I added @marwaneltoukhy and @M0stafaRady as reviewers to asses if this PR is going to have any further impact.