Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LI-Custom-CAF] During the tests will be used this branch #22

Open
wants to merge 80 commits into
base: main
Choose a base branch
from
Open

[LI-Custom-CAF] During the tests will be used this branch #22

wants to merge 80 commits into from

Conversation

lyudmililchev92
Copy link
Contributor

No description provided.

@lyudmililchev92
[TC-18] Add module for keyvault secrets and private endpoint (#17)
53c7f7f 
* TC-5 Add module for private dns zone with vnet links

* fix module name and variable name

* add example tfvars for private dns zone

* fix pre-commit

* add changes for private endpoint inside keyvault

* add local changes in locals.tf in keyvault

* fix duplicated locals

* add reference to private dns zones in keyvault

* fix to not fail in not have private endpoint

* private endpoint not required

* fix not required values

* check for existing private endpoint

* add keyvault secrets

* secret changes

* add default value

* add key vault secret

* fix pre commit

* test TC-18

* fix source folder

* add access policies inside keyvault

* test folder structure

* test fix of keyvault variable

* test module access_policy_

* change module name

* test

* test keyvault id

* test key vault id

* test

* test

* remove client config

* test access policies

* add keyvault each key

* add module update keyvaults

* fix module

* try for each in keyvault module

* try to fix keyvault

* try to fix keyvault module

* fix global settings

* test var global settings

* fix keyvaults resource

* test

* fix keyvault module

* test some minor changes

* test

* format keyvault module

* test

* test access policies

* fix keyvault module

* test access policies

* Test

* test

* fix global settings

* test access policies

* Test

* test

* test

* test keyvault module

* move source outside security

* remove var ffrom local

* test managed idenitties

* test

* test

* test

* test

* test

* test

* test

* test resources output

* fix access policies

* Test

* test

* view settings

* test

* test

* test

* test

* test

* debug

* test

* test

* test two new policies

* test

* test

* test

* check

* test

* Test

* test

* test

* test

* test

* test

* test

* test with try on managed_identity_refs

* 100 percent working version about access policies in different folder structure
@lyudmililchev92
[TC-18] Module update for keyvault private endpoint (#18)
e712b2d 
* Test new module

* remove duplicate variable

* test to map

* test

* test private endpoint

* fix typo in name
@lyudmililchev92
Tc 18 nn (#19)
f1fa9b9 
* test secret module

* update module secrets

* ignore_changes

* fix secrets
@lyudmililchev92
Tc 18 nnn (#20)
3a7830a 
* add changes

* change folder name

* add variable

* test

* test

* test

* test

* test

* test
@lyudmililchev92
Add support for AKS cluster and node pool (#21)
d0a5e93 
* test aks module

* fix node pool vnet

* test

* fix node pool vars

* fix identity blcok

* fix max pods

* test

* test
lyudmililchev92 and others added 24 commits January 19, 2025 20:56
@lyudmililchev92
Role assignment module (#23)
ab6d52d 
* test

* test

* test

* test

* test

* Test

* test

* test new role assignment module

* try another logic

* last test for today :(

* last test for today :(

* test

* test

* test

* test

* test

* test
@lyudmililchev92
add public network access enabled to false
c2f053a
@lyudmililchev92
fix managed identity module for access policies
f84ed86
@lyudmililchev92
test keyvault id
c62c3ca
@lyudmililchev92
test keyvault id
a86109d
@lyudmililchev92
test each key
ce8285c
@lyudmililchev92
test keyvault id
d4f02a2
@lyudmililchev92
Remove variable
471ff78
@lyudmililchev92
AKS Module update (#26)
7b83162 
* Add aks module

* remove duplicated resources

* remove unused variable

* add managed identity ref

* add dns prefix

* fix network data plane

* test with locals

* remove duplicated local variable

* fix network data plane to azure
@lyudmililchev92
Add object ids in role assignments (#27)
3bc290d 
* test with object_ids

* test object_ids

* one more test of new structure
@lyudmililchev92
Add support for access policies with object IDs (#28)
8aa78b7
@lyudmililchev92
add zones to public ip module
3d40309
@lyudmililchev92
add active active to false inside vnet gw
cbddc8e
@lyudmililchev92
add ipsec policy configuration for datasize
8a4d171
@lyudmililchev92
refactor aks module
96cf21c
@lyudmililchev92
fix managed identity id
c21b480
@lyudmililchev92
fix locals about managed identity
c31f2ed
@lyudmililchev92
fix aks module
a620160
@lyudmililchev92
fix aks module with added some configuration
e28a76a
@lyudmililchev92
add networking on the cluster
1476158
@lyudmililchev92
remove temporary name
47b7a38
@lyudmililchev92
test secret provider
92e1945
@lyudmililchev92
add dynamic block
2760c46
@lyudmililchev92
try
5bb12f0
BorislavRaynov and others added 30 commits January 27, 2025 16:29
@BorislavRaynov
TC-17 Add skeleton for linux_virtual_machines module (#16)
fe43305 
* Add skeleton for linux_virtual_machines module

* Add locals

* Add linux vm configs

* Add network interface.

* Fix variables resources in module

* Refactor output

* Refactor output

* Add public key

* Refactor locals

* Refactor subnet id in locals

* Refactor subnet id in locals

* Refactor subnet id in locals

* Refactor nic ip config

* Refactor locals

* Refactor subnet id in locals

* Refactor code

* Refactor locals

* Refactor public_key

* Refactor public key in locals

* Refactor nic in locals

* Refactor nic in locals

* Refactor nic in locals

* Refactor nic in locals

* Refactor public key in locals

* Refactor public key in locals

* Refactor locals

* Add key creation for each vm

* Refactor to submodules

* refactor nic module

* Refactored locals

* Refactor locals

* Refactor locals

* Refactor module

* Refactor code

* Refactor code

* Refactor modules

* Refactor module

* Refactor code.

* Refactor code

* Refactoring

* Refactor subnet_id

* Refacotr ouputs

* Refactor module

* Refactor module

* Refactor subnet id in loals network interfaces

* Refactor code

* Refactor code

* Refactor locals

* Refactor resource

* Refactor resource

* Refacotr modules

* Refactor code

* Refactor code

* Refactor code

* Refactor code

* Add all_settings for nic

* Refactor code

* Refactor linux vm module

* Refactor locals

* Refactor code

* Refactor code

* Refactor code

* Refactor code

* Refactor code

* Refactor ouputs

* Refactor code

* Remove comments

* Add try on optional configs

* Add windows virtual machine module

* Refacotr settings in top level module

* Remove comments

* Refactor modules

* Add local global settings

* Add secret to keyvault

* Remove not needed resources

* Refactor secret

* Refactor networking.tf

* Refactor provider

* Refactor provider.tf

* Import data

* Refactor code

* Add keyvault module to vm module resources

* Remove unnecessary resources

* Remove unnecessary resource

* Add example for virtual_machines module

* Add tags

* Refactor tags

* Refactor tags

* Refactor tags

* Change ip alocation default value

* Convert nics output to list

* Remove try in network_interface_ids

* Refactor locals

* Add access policy

* Refactor code

* Restore module files

* Refactor code

* Fix linting

* Refacror code

* Add storage account module

* Add dynamic block
@lyudmililchev92
[AC-22] Add managed disk module (#31)
d8941a1 
* Add managed disk caf module

* Add example file

* fix pre commit
@BorislavRaynov
TC-6 Add module for ACR with private endpoint (#30)
f13070f 
* Add blank acr tfs

* Add container registries module

* Add ID in outputs.tf

* Change georeplications location value

* Add private endpoint for container registry

* Refactor private_connection_resource_id value

* Refactor subnet id

* Refactor subnet_id

* Refactor subnet id locals

* Refactor locals

* Add example for container registries

* Add private dns zone module for the ACR mdoule

* Remove resource variable

* Refactor locals

* Remove resources from pDNS module

* Remove resources from variables in ACR module

* Add pDNS name export

* Change namings in privae endpoint

* Add example for container registrie

* Refactor code according to the PR's comments

* Add resources to _variables.resources

* Sync with main

* Sync with main branch

* Remove allias from private service connection

* Refactor psc manual connection value

* Removing optional blocks in psc block

* Add "registry" as a soubresource names value

* Refactor example

* Add readme example

* Fix linting

* Fix linting

* Remove VNG from requierd resources

* Add ACR variable

* Add storage account module

* Add vnet peering to var.resources

* Resolve comments
@lyudmililchev92
add zone for managed disks
f4ad65b
@lyudmililchev92
fix ignore changes
2dc3b9a
@lyudmililchev92
add performance tier
9eecda2
@lyudmililchev92
Add support for virtual networks
ee5007e
@BorislavRaynov
[TC-24] Add module for Log analytics workspace (#32)
b31add7 
* Add skeleton for log workspace module

* Add log worksapce resource

* Add locals

* Change global settings to local.global

* Add all the optional block for the module

* Change default value for dynamic blocks

* Change default values in optional blocks

* Change default values in resource

* Change default values in resource

* Change identity type default value

* Fix references in the dynamic block.

* Fix references in timouts block

* Fix value in identity block

* Change identity reference

* Change identity_ids default value

* Refactor identity_ids value

* Change for each in identity block

* Add the option to use managed identity

* Change ref in locals

* Change identity_ids value

* Change identity_ids value

* Fix identity_ids value

* Remove comments

* Fix return value of identity_ids

* Change dynamic block values

* Fix error in dynamic block

* Change dynamic identity value

* Change identity_ids definition

* Remove comments

* Add example

* Fix linting

* Change settings description

* Fix linting role assignments
@BorislavRaynov
[TC-25] Add module for Log analytics Data export rule (#33)
0b58de4 
* Add skeleton for the module

* Add dynamic block for timeouts

* Add data_collection_rule to workspace

* Add rule in workspace

* Remove data_collection_rule_id from locals

* Fix typo

* Change output export_rule_id

* Change name ref in rule resource

* Change storage account dependency

* Add dependency

* Use direct value for destination_resource_id

* Remove exported values

* Remove log rule module from workspace module

* Add storage account to moule's resources

* Change destination_resource_id value

* Add example

* Add examples

* Remove identity block

* Add back identity block

* Change examples
@BorislavRaynov
[TC-23] Add module for Container Group (#34)
ed92fd1 
* Add skeleton for the module

* Add container group resource

* Refactor dynamic block

* Remove var from container block

* Remove var from nested dynamic blocks

* Remove try of log_analytics block

* Export log workspaces keys

* Chenge log_analytics block to optional

* Change diagnostics to required

* Change from key to value in log_analytics block

* Add workspace in locals

* Handle workspace in locals

* Add workspace in container groups resources

* Add try in identity_ids locals

* Remove wrong dependency

* Fix typo

* Add env variables

* Change env_variables definition

* Refactor variables

* Refactor comments

* Add example

* Remove resource from module
@BorislavRaynov
[TC-27] Add module for Keyvault key (#35)
3edf774 
* Add skeleton

* Add vnets to module's resources

* Remove Rg from locals

* Remove RG tags

* Fix typo

* Refactor automatic dynamic block

* Change for each in automatic block

* Change content in automatic block

* Fix automatic value

* Test rotation policy

* Test policy

* Revert back changes

* Revert back the rotaion policy block

* Change for_each in rotaion policy

* Refactor rotation policy

* Test rotaion policy

* Revert back automatic block

* Refacotr automatic block

* Test with refactored rotaion policy

* Fix typo

* Test policy block

* Test automatic block

* Test rotation policy

* Test policy

* Test policy

* Test policy

* Test rotation policy

* Test policy

* Test policy

* Add try

* Add output

* Refactor policy block

* Try debug

* Remove comments

* Add example
@lyudmililchev92
Add change to the outputs in the storage account
86b1745
@lyudmililchev92
Add private endpoint for storage account
cfc2de0
@lyudmililchev92
add setting for storage account - nested items to be public
204c00c
@BorislavRaynov
Add module's skeleton
fbc3903
@BorislavRaynov
Remove resources for role definitions
398204a
@BorislavRaynov
[TC-23] Add kv-key-reference (#36)
71c1103 
* Add keyvault key reference

* Test with two identities

* Change type value on identity block

* Remove comments

* Change ports block to handle multiple ports

* Fix output typo

* Refactor diagnostics to work with one instance

* Handle one block in log analytics

* Change handle multiple exposed ports

* Fix typo in exposed ports block

* Refactor module

* Add more resources in example

* Add versionless_id for kv-key

* Refactor diagnostics block
@BorislavRaynov
[TC-26] Add module for Role definiton (#37)
ce354db 
* Add module's skeleton

* Fix typo in module's source

* Handle getting id not raising error

* Fix typo in scope block

* Test with different module referenci ni locals

* Add debug

* Fix typo in loclas

* Remove comments

* Add example

* Set the definition to subscription level

* Refactor scope value

* Remove ResourceGroup from the module
@BorislavRaynov
[TC-43] Add module for Custom role assignment (#38)
272b8fc 
* Add module's skeleton

* Add custom role module

* Fix example

* Remove for_each in top level role assignment module

* Remove comments

* Remove comments

* Add example
@BorislavRaynov @lyudmililchev92
[TC-41] Refactor dev branch (#39)
733f552 
* Refactor virtual machines module

* Refactor storage accounts module

* Refactor role definitions module

* Refactor managed identities module

* Refcator role assignments module

* Refactor managed disks module

* Refactor log log analytics workspaces module

* Refactor log_analytics data export rules module

* Refactor keyvaults module

* Refactor variables

* Refactor aks module

* Refactor networking module

* Refactor vng connection module

* Refactor global vars

* Add default value for bypass in kevault network rules

* Add private dns zones into storage account main module call

* fix ipsec_policy

* fix pre commit

---------

Co-authored-by: lyudmililchev92 <[email protected]>
@BorislavRaynov
[TC-29] Add module for NSG (#40)
46c56b0 
* Add module's skeleton

* Add all blocks for the module

* Add example for the module
@BorislavRaynov
[TC-40] Add module for NAT-GW (#41)
ed214de 
* Add module's blocks

* Add example

* Add for each in nsg module

* Remove for each in module

* Change file name

* Add for each

* Add example
@BorislavRaynov
[TC-37] Add module for Workbooks (#42)
9eed0ef 
* Add all the blocks for the module

* Add random name

* Change folder name

* Add example
@BorislavRaynov
[TC-30] Add module for private endpoint (#43)
b334775 
* Add module's skeleton

* Add all the blocks for the module

* Change pc_resource_id value in locals

* Add stacc module to resources

* Change subnet_id value

* Add private dns zone group to resources

* Remove variables

* Add example

* Remove comments

* Fix typo

* Change subresource_names to required

* Update example

* Move logic for private_connection_resource_id in locals

* Move logic for subnet_id in locals
@BorislavRaynov
[TC-44] Add module Private DNS A record (#44)
474747c 
* Add module's skeleton

* Remove comments

* Remove resource from the required

* Move module to networking folder

* Move modules to networking folder

* Add correct export for zone name in locals
@BorislavRaynov
[TC-38] Add module for NSG Association (#45)
4db9f44 
* Add required block's for the module

* Remove tags from locals

* Fix typo in locals

* Add example

* Add nsg association at subnet level

* Add subnet id to locals

* Add for_each on nsg resource

* Remove comments
@BorislavRaynov
[TC-39] Add module for MSSQL-MI (#46)
6db1516 
* Add module's skeleton

* Add module's attributes

* Change folder name

* Remove depends_on block

* Remove comments

* Add example

* Add comments
@BorislavRaynov
[TC-35] Add module for AzureAD App (#47)
046658e 
* Add module's skeleton

* Add module's attributes

* Remove second param in can functions

* Remove outputs

* Import data

* Fix wrong name value

* Remove imported data

* Fix tags

* Remove tags

* Set owner in locals

* Add feature tags

* Remove comments

* Fix typo

* Add toset function

* Remove owners from locals

* Add feature_tags dynamic block

* Add example

* Remove locals

* Fix feature tags

* Remove comments
@BorislavRaynov
[TC-34] Add module for AzureAD SP + password (#48)
6d5545a 
* Add module's skeleton

* Remove RG tags from locals

* Add ouputs

* Change tags to set

* Add example
@BorislavRaynov @lyudmililchev92
[TC-41] Refactor DEV branch (#49)
be65fe7 
* Refactor virtual machines module

* Refactor storage accounts module

* Refactor role definitions module

* Refactor managed identities module

* Refcator role assignments module

* Refactor managed disks module

* Refactor log log analytics workspaces module

* Refactor log_analytics data export rules module

* Refactor keyvaults module

* Refactor variables

* Refactor aks module

* Refactor networking module

* Refactor vng connection module

* Refactor global vars

* Add default value for bypass in kevault network rules

* Add private dns zones into storage account main module call

* fix ipsec_policy

* fix pre commit

* Move keyvault-key into keyvault

---------

Co-authored-by: lyudmililchev92 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitiko mitiko Awaiting requested review from mitiko mitiko is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyudmililchev92 @BorislavRaynov