Skip to content

Updated key to avoid collisions at time zero#11

Open
theo-rogers wants to merge 1 commit intoegorovsa:masterfrom
theo-rogers:patch-1
Open

Updated key to avoid collisions at time zero#11
theo-rogers wants to merge 1 commit intoegorovsa:masterfrom
theo-rogers:patch-1

Conversation

@theo-rogers
Copy link

Using just fromMs as a key will end up in 0 being a key when time = 0. This is likely to cause a key collision.

Using just `fromMs` as a key will end up in `0` being a key when time = 0. This is likely to cause a key collision.
@egorovsa
Copy link
Owner

Hi there! Thanks for your PR.
Could you please clarify what the keys collisions do you mean?
I see it if only you provide two timecodes with fromMs = 0 whereas this is a mistaken props.
So I can't see any cases where two timecodes have keys 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants