Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/517 ethers helper.rs #519

Merged
merged 15 commits into from
Aug 3, 2023

Conversation

Godspower-Eze
Copy link
Contributor

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.90% ⚠️

Comparison is base (eb60c24) 50.75% compared to head (881ce0c) 49.85%.
Report is 4 commits behind head on main.

❗ Current head 881ce0c differs from pull request most recent head e85342e. Consider uploading reports for the commit e85342e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   50.75%   49.85%   -0.90%     
==========================================
  Files          14       14              
  Lines        2530     2427     -103     
==========================================
- Hits         1284     1210      -74     
+ Misses       1246     1217      -29     
Files Changed Coverage Δ
crates/beerus-core/src/ethers_helper.rs 78.94% <ø> (-14.67%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drspacemn drspacemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drspacemn drspacemn merged commit a7f494c into eigerco:main Aug 3, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants