Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Init Beerus from config only #520

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

tonypony220
Copy link
Contributor

@tonypony220 tonypony220 commented Aug 3, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Issue Number: #516

What is the new behavior?

BeerusLightClient::new creates client from config only

Added function BeerusLightClient::new_from_clients which preserve old BeerusLightClient::new behaviour for testing purpose

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 70.58% and project coverage change: -0.47% ⚠️

Comparison is base (eb60c24) 50.75% compared to head (7dcd000) 50.28%.
Report is 7 commits behind head on main.

❗ Current head 7dcd000 differs from pull request most recent head 818934b. Consider uploading reports for the commit 818934b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   50.75%   50.28%   -0.47%     
==========================================
  Files          14       14              
  Lines        2530     2426     -104     
==========================================
- Hits         1284     1220      -64     
+ Misses       1246     1206      -40     
Files Changed Coverage Δ
crates/beerus-core/src/ethers_helper.rs 78.94% <ø> (-14.67%) ⬇️
crates/beerus-rpc/src/main.rs 0.00% <0.00%> (ø)
crates/beerus-core/src/lightclient/beerus.rs 64.90% <85.71%> (+0.47%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonypony220 tonypony220 marked this pull request as ready for review August 6, 2023 15:46
@drspacemn drspacemn enabled auto-merge (squash) August 7, 2023 17:10
Copy link
Contributor

@drspacemn drspacemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I definitely like the simplicity of initialization here

@drspacemn drspacemn merged commit b743176 into eigerco:main Aug 7, 2023
2 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants