Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: the starknet_addDeployAccountTransaction rpc method is failing #535

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

Aragar199
Copy link
Contributor

@Aragar199 Aragar199 commented Aug 10, 2023

Refactor add_deploy_account_transaction and fixed hurl file

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

Issue Number: #522

Does this introduce a breaking change?

  • Yes
  • No

@Aragar199 Aragar199 changed the title Fix 522 Fix bug: the starknet_addDeployAccountTransaction rpc method is failing Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 41.37% and project coverage change: -0.15% ⚠️

Comparison is base (eb60c24) 50.75% compared to head (14af8e0) 50.60%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
- Coverage   50.75%   50.60%   -0.15%     
==========================================
  Files          14       14              
  Lines        2530     2411     -119     
==========================================
- Hits         1284     1220      -64     
+ Misses       1246     1191      -55     
Files Changed Coverage Δ
crates/beerus-core/src/ethers_helper.rs 78.94% <ø> (-14.67%) ⬇️
crates/beerus-core/src/lightclient/starknet/mod.rs 47.19% <0.00%> (-1.65%) ⬇️
crates/beerus-rpc/src/api.rs 0.00% <ø> (ø)
crates/beerus-rpc/src/lib.rs 15.86% <0.00%> (+0.65%) ⬆️
crates/beerus-rpc/src/main.rs 0.00% <0.00%> (ø)
crates/beerus-core/src/lightclient/beerus.rs 64.90% <85.71%> (+0.47%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drspacemn drspacemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drspacemn drspacemn merged commit 3b7bb41 into eigerco:main Aug 21, 2023
3 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants