-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug: the starknet_getEvents rpc method is failing bug #537
Fix bug: the starknet_getEvents rpc method is failing bug #537
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 50.75% 50.28% -0.47%
==========================================
Files 14 14
Lines 2530 2426 -104
==========================================
- Hits 1284 1220 -64
+ Misses 1246 1206 -40
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try running from:
and to:
blocks as latest
to see if we can not hard code the block values? @tonypony220
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you plan on implementing Alex's suggestion?
Yes, it works. And without |
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #526
What is the new behavior?
Does this introduce a breaking change?
Other information