Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: the starknet_getEvents rpc method is failing bug #537

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

tonypony220
Copy link
Contributor

@tonypony220 tonypony220 commented Aug 13, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Issue Number: #526

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch coverage: 70.58% and project coverage change: -0.47% ⚠️

Comparison is base (eb60c24) 50.75% compared to head (993eccb) 50.28%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   50.75%   50.28%   -0.47%     
==========================================
  Files          14       14              
  Lines        2530     2426     -104     
==========================================
- Hits         1284     1220      -64     
+ Misses       1246     1206      -40     
Files Changed Coverage Δ
crates/beerus-core/src/ethers_helper.rs 78.94% <ø> (-14.67%) ⬇️
crates/beerus-rpc/src/main.rs 0.00% <0.00%> (ø)
crates/beerus-core/src/lightclient/beerus.rs 64.90% <85.71%> (+0.47%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Aragar199 Aragar199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try running from: and to: blocks as latest to see if we can not hard code the block values? @tonypony220

Copy link
Contributor

@drspacemn drspacemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you plan on implementing Alex's suggestion?

@tonypony220
Copy link
Contributor Author

Can you try running from: and to: blocks as latest to see if we can not hard code the block values? @tonypony220

Yes, it works. And without to block too.
@Aragar199

@Aragar199 Aragar199 merged commit 03c98b3 into eigerco:main Aug 16, 2023
4 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants