Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/498 beerus.rs #538

Merged
merged 20 commits into from
Aug 17, 2023
Merged

Test/498 beerus.rs #538

merged 20 commits into from
Aug 17, 2023

Conversation

Godspower-Eze
Copy link
Contributor

@Godspower-Eze Godspower-Eze commented Aug 14, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Issue Number: #498

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 70.58% and project coverage change: +3.41% 🎉

Comparison is base (eb60c24) 50.75% compared to head (0529949) 54.16%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
+ Coverage   50.75%   54.16%   +3.41%     
==========================================
  Files          14       14              
  Lines        2530     2426     -104     
==========================================
+ Hits         1284     1314      +30     
+ Misses       1246     1112     -134     
Files Changed Coverage Δ
crates/beerus-core/src/ethers_helper.rs 78.94% <ø> (-14.67%) ⬇️
crates/beerus-rpc/src/main.rs 0.00% <0.00%> (ø)
crates/beerus-core/src/lightclient/beerus.rs 84.77% <85.71%> (+20.35%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drspacemn drspacemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drspacemn drspacemn merged commit 5aaac54 into eigerco:main Aug 17, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
@drspacemn
Copy link
Contributor

@all-contributors please add @Godspower-Eze for code,testing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants