Skip to content

Add the ability to specify HTTP request parameters in all, filter, where, and query #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d3-steichman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add the ability to specify HTTP request parameters in all, filter, where, and query #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions quickbooks/mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ class ListMixin(object):
qbo_json_object_name = ""

@classmethod
def all(cls, order_by="", start_position="", max_results=100, qb=None):
def all(cls, order_by="", start_position="", max_results=100, qb=None, params=None):
"""Returns list of objects containing all objects in the QuickBooks database"""
if qb is None:
qb = QuickBooks()
Expand All @@ -274,21 +274,22 @@ def all(cls, order_by="", start_position="", max_results=100, qb=None):
if max_results:
select += " MAXRESULTS {0}".format(max_results)

return cls.query(select, qb=qb)
return cls.query(select, qb=qb, params=params)

@classmethod
def filter(cls, order_by="", start_position="", max_results="", qb=None, **kwargs):
def filter(cls, order_by="", start_position="", max_results="", qb=None, params=None, **kwargs):
"""
:param order_by:
:param start_position:
:param max_results:
:param qb:
:param params: HTTP request params
:param kwargs: field names and values to filter the query
:return: Filtered list
"""
return cls.where(build_where_clause(**kwargs),
start_position=start_position, max_results=max_results, order_by=order_by,
qb=qb)
qb=qb, params=params)

@classmethod
def choose(cls, choices, field="Id", qb=None):
Expand All @@ -301,13 +302,14 @@ def choose(cls, choices, field="Id", qb=None):
return cls.where(build_choose_clause(choices, field), qb=qb)

@classmethod
def where(cls, where_clause="", order_by="", start_position="", max_results="", qb=None):
def where(cls, where_clause="", order_by="", start_position="", max_results="", qb=None, params=None):
"""
:param where_clause: QBO SQL where clause (DO NOT include 'WHERE')
:param order_by:
:param start_position:
:param max_results:
:param qb:
:param params: HTTP request params
:return: Returns list filtered by input where_clause
"""
if where_clause:
Expand All @@ -325,19 +327,20 @@ def where(cls, where_clause="", order_by="", start_position="", max_results="",
select = "SELECT * FROM {0} {1}{2}{3}{4}".format(
cls.qbo_object_name, where_clause, order_by, start_position, max_results)

return cls.query(select, qb=qb)
return cls.query(select, qb=qb, params=params)

@classmethod
def query(cls, select, qb=None):
def query(cls, select, qb=None, params=None):
"""
:param select: QBO SQL query select statement
:param qb:
:param params: HTTP request params
:return: Returns list
"""
if not qb:
qb = QuickBooks()

json_data = qb.query(select)
json_data = qb.query(select, params=params)

obj_list = []

Expand Down