fix(cli): invalid type error when missing exclude flag #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR resolves an error caused by parsing workspace configuration and merging it with user-provided CLI arguments/flags. Users had to explicitly add the `exclude` flag or provide it's value in the licensarc.json file, which is ultimately undesirable. Now, users are not required to explicitly provide this flag nor add it to the licensarc.json file. Closes #66
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
+ Coverage 70.3% 70.4% +0.1%
=======================================
Files 25 25
Lines 2760 2777 +17
=======================================
+ Hits 1941 1956 +15
- Misses 819 821 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an error caused by parsing workspace configuration and merging it with user-provided CLI arguments/flags. Users had to explicitly add the
excludeflag or provide it's value in the licensarc.json file, which is ultimately undesirable.Now, users are not required to explicitly provide this flag nor add it to the licensarc.json file.
Closes #66
✅ Checks
ℹ Additional Information