-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable Dockerfile check for dependabot #2233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the same for apm-agent-nodejs.git FWIW.
(note: I don't have permission to merge this) |
ping @xrmx |
Don't we have already renovate for that? |
Closing this since we already have renovate. I don't merge renovate PRs often because they bump the major python version image that I don't want to. |
Sorry for reopening and for the late reply 😓
I think renovate config is only enabled for chainguard images: apm-agent-python/renovate.json Line 4 in a15ec54
I'll leave it up to you and the python agent team to decide whether you want to extend the config to other docker images or want to use renovate but the image should be kept up to date.
I don't think this is ok :( |
I would like to use just one tool for the same purpose
That would be great of course |
Do we mean "major" version here? (I'm reading this in terms of Semantic Versioning) #2206 seems to be bumping minor version of Python I think yes, if we don't want to have Python minor bumps happening automagically, but only when a human triggers them via the Dependency Dashboard, then that's very achievable - wanna drop into the #renovate channel and discuss, if you need a hand? |
Will do thanks |
Handing the update to dependabot has been merged in #2246 . Now I just need to configure it 😓 |
What does this pull request do?
keep docker image up to date
Related issues
Closes #ISSUE