Skip to content

feat: do not include latest line in error message #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kruskall wants to merge 2 commits into
base: main
Choose a base branch
from

test: update tests

4651105
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

feat: do not include latest line in error message #543

test: update tests
4651105
Select commit
Loading
Failed to load commit list.
GitHub Actions / benchdiff-result succeeded Sep 25, 2025 in 0s

Benchdiff Results

Benchmark Command: go test ./... -run ^ -bench . -count 5 -benchtime 100ms -cpu 1,2 -benchmem

HEAD sha: 4651105

Base sha: e9e8f69

Degraded: false

Details

pkg: github.com/elastic/apm-data/codec
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
Encode/format=json 25865 0% 25846.2 2% ~ (p=0.905 n=4+5)
Encode/format=json-2 13694.6 1% 14611.2 20% ~ (p=0.222 n=5+5)
Encode/format=vtproto 4962.2 0% 4900.4 0% -1.25% (p=0.008 n=5+5)
Encode/format=vtproto-2 2754.6 2% 2741.2 2% ~ (p=0.421 n=5+5)
Decode/format=json 128462 7% 122438 3% ~ (p=0.151 n=5+5)
Decode/format=json-2 61039 6% 61212.2 3% ~ (p=0.841 n=5+5)
Decode/format=vtproto 17213.2 0% 17541.8 1% +1.91% (p=0.016 n=4+5)
Decode/format=vtproto-2 10359.2 2% 10405.4 1% ~ (p=0.690 n=5+5)
name old bytes/op (bytes/op) ± new bytes/op (bytes/op) ± delta ±
Encode/format=json 6564 0% 6564 0% ~ (all equal)
Encode/format=json-2 6564 0% 6564 0% ~ (all equal)
Encode/format=vtproto 2775 0% 2775 0% ~ (all equal)
Encode/format=vtproto-2 2775 0% 2775 0% ~ (all equal)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
Encode/format=json 7592 0% 7592 0% ~ (all equal)
Encode/format=json-2 7593 0% 7593 0% ~ (all equal)
Encode/format=vtproto 3072 0% 3072 0% ~ (all equal)
Encode/format=vtproto-2 3072 0% 3072 0% ~ (all equal)
Decode/format=json 14283 0% 14282 0% ~ (p=0.302 n=5+5)
Decode/format=json-2 14282.6 0% 14281.8 0% ~ (p=0.317 n=5+5)
Decode/format=vtproto 12952 0% 12952 0% ~ (all equal)
Decode/format=vtproto-2 12952 0% 12952 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
Encode/format=json 26 0% 26 0% ~ (all equal)
Encode/format=json-2 26 0% 26 0% ~ (all equal)
Encode/format=vtproto 1 0% 1 0% ~ (all equal)
Encode/format=vtproto-2 1 0% 1 0% ~ (all equal)
Decode/format=json 379 0% 379 0% ~ (all equal)
Decode/format=json-2 379 0% 379 0% ~ (all equal)
Decode/format=vtproto 348 0% 348 0% ~ (all equal)
Decode/format=vtproto-2 348 0% 348 0% ~ (all equal)

pkg: github.com/elastic/apm-data/input/elasticapm/internal/decoder
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
NDStreamDecoder 234.9 6% 231.24 2% ~ (p=0.452 n=5+5)
NDStreamDecoder-2 124.02 5% 123.22 4% ~ (p=0.841 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
NDStreamDecoder 72 0% 72 0% ~ (all equal)
NDStreamDecoder-2 72 0% 72 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
NDStreamDecoder 4 0% 4 0% ~ (all equal)
NDStreamDecoder-2 4 0% 4 0% ~ (all equal)

pkg: github.com/elastic/apm-data/model/modeljson
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
APMEventToJSON/to-json 15029.2 7% 14248 4% ~ (p=0.095 n=5+5)
APMEventToJSON/to-json-2 12807.4 1% 12573.2 1% -1.83% (p=0.008 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
APMEventToJSON/to-json 2616 0% 2616 0% ~ (all equal)
APMEventToJSON/to-json-2 2616 0% 2616 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
APMEventToJSON/to-json 38 0% 38 0% ~ (all equal)
APMEventToJSON/to-json-2 38 0% 38 0% ~ (all equal)
View more details on GitHub Actions