Skip to content

fix: add missing span kind to otel traces #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kruskall wants to merge 1 commit into
base: main
Choose a base branch
from

fix: add missing span kind to otel traces

dd952df
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

fix: add missing span kind to otel traces #559

fix: add missing span kind to otel traces
dd952df
Select commit
Loading
Failed to load commit list.
GitHub Actions / benchdiff-result succeeded Nov 26, 2025 in 0s

Benchdiff Results

Benchmark Command: go test ./... -run ^ -bench . -count 5 -benchtime 100ms -cpu 1,2 -benchmem

HEAD sha: dd952df

Base sha: 46a8134

Degraded: false

Details

pkg: github.com/elastic/apm-data/codec
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
Encode/format=json 26138.4 4% 25764 1% ~ (p=0.310 n=5+5)
Encode/format=json-2 13987 3% 13616.8 2% -2.65% (p=0.032 n=5+5)
Encode/format=vtproto 4758.4 1% 4700.2 0% -1.22% (p=0.008 n=5+5)
Encode/format=vtproto-2 2642.2 1% 2604.6 1% -1.42% (p=0.032 n=5+5)
Decode/format=json 123624 4% 123891 3% ~ (p=1.000 n=5+5)
Decode/format=json-2 59387 1% 62196 5% ~ (p=0.111 n=4+5)
Decode/format=vtproto 17094 1% 16966 1% ~ (p=0.151 n=5+5)
Decode/format=vtproto-2 10281 3% 10331.4 4% ~ (p=0.802 n=5+5)
name old bytes/op (bytes/op) ± new bytes/op (bytes/op) ± delta ±
Encode/format=json 6564 0% 6564 0% ~ (all equal)
Encode/format=json-2 6564 0% 6564 0% ~ (all equal)
Encode/format=vtproto 2775 0% 2775 0% ~ (all equal)
Encode/format=vtproto-2 2775 0% 2775 0% ~ (all equal)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
Encode/format=json 7592 0% 7592 0% ~ (all equal)
Encode/format=json-2 7593 0% 7593 0% ~ (all equal)
Encode/format=vtproto 3072 0% 3072 0% ~ (all equal)
Encode/format=vtproto-2 3072 0% 3072 0% ~ (all equal)
Decode/format=json 14282.4 0% 14283.2 0% ~ (p=0.468 n=5+5)
Decode/format=json-2 14282.4 0% 14282.4 0% ~ (p=1.000 n=5+5)
Decode/format=vtproto 12952 0% 12952 0% ~ (all equal)
Decode/format=vtproto-2 12952 0% 12952 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
Encode/format=json 26 0% 26 0% ~ (all equal)
Encode/format=json-2 26 0% 26 0% ~ (all equal)
Encode/format=vtproto 1 0% 1 0% ~ (all equal)
Encode/format=vtproto-2 1 0% 1 0% ~ (all equal)
Decode/format=json 379 0% 379 0% ~ (all equal)
Decode/format=json-2 379 0% 379 0% ~ (all equal)
Decode/format=vtproto 348 0% 348 0% ~ (all equal)
Decode/format=vtproto-2 348 0% 348 0% ~ (all equal)

pkg: github.com/elastic/apm-data/input/elasticapm/internal/decoder
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
NDStreamDecoder 232.2 2% 230.22 2% ~ (p=0.841 n=5+5)
NDStreamDecoder-2 123.68 6% 124.58 3% ~ (p=1.000 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
NDStreamDecoder 72 0% 72 0% ~ (all equal)
NDStreamDecoder-2 72 0% 72 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
NDStreamDecoder 4 0% 4 0% ~ (all equal)
NDStreamDecoder-2 4 0% 4 0% ~ (all equal)

pkg: github.com/elastic/apm-data/model/modeljson
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
APMEventToJSON/to-json 14674.2 8% 14794.6 6% ~ (p=1.000 n=5+5)
APMEventToJSON/to-json-2 12578.2 2% 12770.2 1% +1.53% (p=0.016 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
APMEventToJSON/to-json 2616 0% 2616 0% ~ (all equal)
APMEventToJSON/to-json-2 2616 0% 2616 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
APMEventToJSON/to-json 38 0% 38 0% ~ (all equal)
APMEventToJSON/to-json-2 38 0% 38 0% ~ (all equal)
View more details on GitHub Actions