-
Notifications
You must be signed in to change notification settings - Fork 5k
[beatreceiver] Do not require specifiying otelconsumer output #47693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
@khushijain21 Can you check if we need to clean up references to otelconsumer in |
mauri870
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
It is okay even if we specify otelconsumer output. I did not clean it up in beatconverter because we will eventually get rid of it anyway. Yes, we should perform a similar cleanup task for elastic-agent as well though |
Thanks for confirming! I see that you added a |
leehinman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the change.
* do not require explicit config (cherry picked from commit b80d1e9) # Conflicts: # x-pack/filebeat/fbreceiver/receiver_test.go # x-pack/filebeat/tests/integration/otel_lsexporter_test.go # x-pack/libbeat/cmd/instance/beat.go
Proposed commit message
All beatreceivers will use otelconsumer output by default and it does not require us to specify this explicitly.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
None
Related issues