Skip to content

Conversation

@khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Nov 18, 2025

Proposed commit message

All beatreceivers will use otelconsumer output by default and it does not require us to specify this explicitly.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

None

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@khushijain21 khushijain21 changed the title do not require explicit config [beatreceiver] Do not require specifiying otelconsumer output Nov 18, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 18, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2025
@khushijain21 khushijain21 marked this pull request as ready for review November 18, 2025 11:10
@khushijain21 khushijain21 requested a review from a team as a code owner November 18, 2025 11:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@khushijain21 khushijain21 added skip-changelog backport-8.19 Automated backport to the 8.19 branch labels Nov 18, 2025
@mauri870 mauri870 requested review from mauri870 and removed request for andrzej-stencel November 18, 2025 11:25
@mauri870
Copy link
Member

@khushijain21 Can you check if we need to clean up references to otelconsumer in libbeat/otelbeat/beatconverter/beatconverter_test.go? Also, do we need a similar cleanup task for elastic agent as well?

Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
@khushijain21
Copy link
Contributor Author

@khushijain21 Can you check if we need to clean up references to otelconsumer in libbeat/otelbeat/beatconverter/beatconverter_test.go? Also, do we need a similar cleanup task for elastic agent as well?

It is okay even if we specify otelconsumer output. I did not clean it up in beatconverter because we will eventually get rid of it anyway.

Yes, we should perform a similar cleanup task for elastic-agent as well though

@mauri870
Copy link
Member

Yes, we should perform a similar cleanup task for elastic-agent as well though

Thanks for confirming! I see that you added a Closes comment, which should close the original issue. Mind creating one for elastic-agent? Keeping the original issue open also works for me, either way.

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change.

@khushijain21 khushijain21 merged commit b80d1e9 into elastic:main Nov 19, 2025
115 checks passed
mergify bot pushed a commit that referenced this pull request Nov 19, 2025
* do not require explicit config

(cherry picked from commit b80d1e9)

# Conflicts:
#	x-pack/filebeat/fbreceiver/receiver_test.go
#	x-pack/filebeat/tests/integration/otel_lsexporter_test.go
#	x-pack/libbeat/cmd/instance/beat.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants