[DO NOT MERGE] Add more tests for the ndjson parser behavior #47774
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdner
added
backport-skip
botelastic
bot
added
needs_team
Contributor
🤖 GitHub commentsJust comment with:
|
straistaru
reviewed
Nov 25, 2025
| "log": mapstr.M{ | ||
| "logger": "agent_component.cli", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Shouldn't the input Data have to be something like the case above with 2 "log" keys (which is not possible in a mapstr.M)? Here we have "log" and "log.level" keys.
{
"log.level": "info",
"log": {
"source": "connectors-py-default"
},
"log": {
"logger": "agent_component.cli"
}
}
So, I am not sure these test the actual test case we want to test.
Member
Author
There was a problem hiding this comment.
@straistaru when we expand (de-dot) keys we also face a collision. This is to demonstrate the current behavior of what happens in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for troubleshooting a bug discovered by @straistaru