-
Notifications
You must be signed in to change notification settings - Fork 5k
[9.1](backport #47729) remove otel.component.id and otel.component.kind fields from beat receivers #47787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.1
Are you sure you want to change the base?
Conversation
…eivers (#47729) * remove component id and component kind fields from beat receivers * add real PR link * update integration tests * fix merge mistake (cherry picked from commit ca1c17b) # Conflicts: # x-pack/filebeat/input/gcppubsub/otel_test.go # x-pack/filebeat/tests/integration/otel_lsexporter_test.go # x-pack/filebeat/tests/integration/otel_test.go # x-pack/libbeat/outputs/otelconsumer/otelconsumer.go # x-pack/libbeat/outputs/otelconsumer/otelconsumer_test.go # x-pack/metricbeat/mbreceiver/receiver_test.go
|
Cherry-pick of ca1c17b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
🤖 GitHub commentsJust comment with:
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
@leehinman I see the build is green, can we merge this? |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Proposed commit message
remove
otel.component.idandotel.component.kindfrom events that were generated by beat receivers.The cost of sending the extra data in every event was found to be not worth the value of having the fields.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
If anyone was using the fields to track beat receiver events, they won't be available anymore. However, the fields we not documented publicly and were not part of an API.
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #47729 done by [Mergify](https://mergify.com).