Skip to content

Harden docs-review substitution suggestions#118

Merged
theletterf merged 1 commit intomainfrom
fab/harden-docs-review-suggestions
Apr 28, 2026
Merged

Harden docs-review substitution suggestions#118
theletterf merged 1 commit intomainfrom
fab/harden-docs-review-suggestions

Conversation

@theletterf
Copy link
Copy Markdown
Member

Summary

  • Make the docs-review suggestion-block guidance conditional on a pre-output checklist.
  • Add a hard rule that prevents GitHub suggestion blocks when the original line or replacement contains Elastic {{...}} substitution syntax.
  • Recompile the generated gh-aw lock file so the stricter prompt ships with the workflow.

Test plan

  • Ran make compile successfully with 0 errors and 0 warnings.
  • Checked lints for .github/workflows/gh-aw-docs-review.md.

Made with Cursor

Require a pre-output checklist before creating suggestion blocks so Elastic substitution syntax is never included in apply-ready review suggestions.

Co-authored-by: GPT-5.5 <gpt-5.5@openai.com>
Made-with: Cursor
@theletterf theletterf requested a review from a team as a code owner April 28, 2026 07:13
@theletterf theletterf requested a review from cotti April 28, 2026 07:13
@theletterf theletterf self-assigned this Apr 28, 2026
@theletterf theletterf added the fix label Apr 28, 2026
@theletterf theletterf merged commit 076f02b into main Apr 28, 2026
3 of 4 checks passed
@theletterf theletterf deleted the fab/harden-docs-review-suggestions branch April 28, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant