Redirect fixes #2267
Draft
Redirect fixes #2267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2264
(WIP, checking for more incorrect scenarios)
This PR fixes the following scenarios involving redirect sanitization:
Empty redirect targets
An incorrect input for the redirect target (such as a cross-link not registered in the link index) output an error, but didn't properly register one at the collector. This caused docs-builder to proceed, yielding an empty string as a resolved path.
At a later point in the assemble process, during key-value store updates, the redirect was being set as an empty string.