-
Notifications
You must be signed in to change notification settings - Fork 450
[RFC] Stage 1: Introducing new field in ECS Rule fields #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smriti0321
wants to merge
16
commits into
elastic:main
Choose a base branch
from
smriti0321:rule-fields
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8f880e8
Update 0000-rfc-template.md
smriti0321 0bee3ac
Update 0000-rfc-template.md
smriti0321 8ee34ce
Merge branch 'main' into rule-fields
ebeahan 0dce6ad
Renaming the template file with recommended name
smriti0321 6a66ed1
Resolving conflicts
smriti0321 af356f6
Removing Tag Field
smriti0321 8fcb9b7
Resolving comments from @trisch-me
smriti0321 63e9f39
Moving file to rfcs/text folder as per @trisch-me comment. using next…
smriti0321 9f2c005
I saw number 44 was used in a recent RFC, using next number in series
smriti0321 660404c
Merge branch 'main' into rule-fields
trisch-me a8244ca
Merge branch 'main' into rule-fields
smriti0321 2cc62d6
Merge branch 'elastic:main' into rule-fields
smriti0321 a6be992
adding stage 1 yml for rule field
smriti0321 d677cec
Adhering to array json syntax
smriti0321 ab569f5
Merge branch 'main' into rule-fields
mjwolf 2162689
changing type to text
smriti0321 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --- | ||
| - name: rule | ||
| fields: | ||
| - name: remediation | ||
| level: extended | ||
| type: wildcard | ||
| short: Recommended remediation steps if the rule evaluation fails | ||
| description: > | ||
| Used to capture remediation instructions that come from the benchmark / framework the rule is from | ||
| example: > | ||
| '["Perform the following to enable MFA: | ||
| From Console: | ||
| Sign in to the AWS Management Console and open the IAM console at 'https://console.aws.amazon.com/iam/' | ||
| In the left pane, select Users. | ||
| and so on", "From cli: <comman>"]' | ||
| normalize: | ||
| - array | ||
|
|
||
|
|
||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would remediations usually be human-readable? In that case, using
texttype could be better than wildcard: https://www.elastic.co/guide/en/elasticsearch/reference/current/keyword.html#wildcard-field-typeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjwolf I have created a PR (#2448) for the suggested changes in https://github.com/elastic/ecs/blob/main/rfcs/text/0046-additional-rule-field.md. Please let me know if thats the right way.