-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golangci-lint to v2.0.2 #299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
leehinman
previously approved these changes
Mar 26, 2025
pierrehilbert
previously approved these changes
Mar 26, 2025
mauri870
previously approved these changes
Mar 26, 2025
056975b
mauri870
reviewed
Mar 27, 2025
Folks, I finished updating all configuration files. It's ready for review again. |
13 tasks
mauri870
previously approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I don't see anything obviously wrong with the config.
fyi i update the linter to |
leehinman
reviewed
Mar 31, 2025
…ate-golangci-lint
leehinman
approved these changes
Mar 31, 2025
💚 Build Succeeded
History
cc @belimawr |
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elastic/beats#42026 Is updating the GitHub Actions and lint configuration (
.golangci.yml
) to V2. Because we need a total of 3 PRs to get all changes into Beats, there will be a brief period when runningmage llc
on Beats will fail due to the version miss-match.What does this PR do?
See title
Why is it important?
It fixes some issues we're seeing in Beats, e.g:
Checklist
I have added tests that prove my fix is effective or that my feature works## Author's ChecklistRelated issues
could not load export data: internal error in importing "sync/atomic"
beats#43489