Enable GODEBUG=fips140=only tests in buildkite. #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable unit tests with GODEBUG=fips140=only and -tags=requirefips in buildkite. This is a basic check to make sure we don't accidently add non-compliant crypto when in FIPS mode. When these test are ran, the encrypted private key tests in transport/tlscommon are skipped, the -tags=requirefips tests check that an error is returned, however if fips140=only is set the test will panic. Add a new V2 file keystore that is used with requirefips. This implementation uses NewGCMWithRandomNonce. File keystore support is currently disabled in FIPS artifacts we produce.
michel-laterman
added
enhancement
michel-laterman
requested review from
khushijain21,
VihasMakwana and
pkoutsovasilis
and removed request for
a team
|
Requires update to go 1.24: #303 |
|
Requires linter update: #304 |
mauri870
reviewed
Mar 31, 2025
simitt
reviewed
Mar 31, 2025
This is a library, we can't drop a supported version of go. go1.24 specific code should be guarded by build tags (e.g. ) |
michel-laterman
commented
Apr 2, 2025
mauri870
reviewed
Apr 2, 2025
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable unit tests with GODEBUG=fips140=only and -tags=requirefips in buildkite. This is a basic check to make sure we don't accidently add non-compliant crypto when in FIPS mode.
When these test are ran, the encrypted private key tests in transport/tlscommon are skipped, the -tags=requirefips tests check that an error is returned, however if fips140=only is set the test will panic.
Add a new V2 file keystore that is used with requirefips. This implementation uses NewGCMWithRandomNonce. File keystore support is currently disabled in FIPS artifacts we produce.
Why is it important?
We want automated testing to ensure we don't accidentally introduce non-compliant code
Checklist