Skip to content

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Jul 19, 2025

Summary

This is meant as a quick patch for #2687 to correct the wrong domain usage on niced axes. Currently, the domains can render incorrectly and misalign/misrepresent chart geometries relative to the axes.

This fix will temporarily disable the adaptive ticks only on niced domains. The result is slightly inferior tick labels in favor of accuracy.

Zight Recording 2025-07-19 at 04 55 05 PM

Details

This is meant as a quick fix until a true solution (#2688) can be thoroughly reviewed.

Issues

Patch for #2687

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • All related issues have been linked (i.e. closes #123, fixes #123)

@nickofthyme nickofthyme added :axis Axis related issue :data Data/series/scales related issue :xy Bar/Line/Area chart related labels Jul 19, 2025
@nickofthyme nickofthyme requested a review from markov00 July 19, 2025 22:01
@nickofthyme
Copy link
Collaborator Author

buildkite update screenshots

@nickofthyme
Copy link
Collaborator Author

buildkite test this

@nickofthyme nickofthyme merged commit 5f9d946 into elastic:main Jul 23, 2025
14 checks passed
@nickofthyme nickofthyme deleted the disable-nice-adaptive-ticks branch July 23, 2025 17:28
nickofthyme pushed a commit that referenced this pull request Jul 23, 2025
## [70.1.2](v70.1.1...v70.1.2) (2025-07-23)

### Bug Fixes

* **axis:** disable nice adaptive ticks ([#2689](#2689)) ([5f9d946](5f9d946))
andrimal added a commit to elastic/kibana that referenced this pull request Sep 25, 2025
…nested tooltip colors (#236341)

fix #203021

The tooltip no longer shows wrong color for nested slices. This issue
was caused when nested layers shared the same label and value.

## Summary

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@elastic/charts](https://togithub.com/elastic/elastic-charts) |
dependencies | patch | [`70.1.1` ->
`70.1.4`](elastic/elastic-charts@v70.1.1...v70.1.4)
|

---

### Release Notes

##
[70.1.4](elastic/elastic-charts@v70.1.3...v70.1.4)
(2025-09-24)


### Bug Fixes

* **partition:** fix tooltip nested colors
([#2717](elastic/elastic-charts#2717)) [70.x]
([#2736](elastic/elastic-charts#2736))
([8caab26](elastic/elastic-charts@8caab26))
* **partition:** fix tooltip nested colors
([#2717](elastic/elastic-charts#2717)) [70.x]
([#2741](elastic/elastic-charts#2741))
([c888166](elastic/elastic-charts@c888166))


### Reverts

* **partition:** fix tooltip nested colors [70.x]
([#2739](elastic/elastic-charts#2739))
([b2b0cba](elastic/elastic-charts@b2b0cba)),
closes [#2717](elastic/elastic-charts#2717)
[#2736](elastic/elastic-charts#2736)

##
[70.1.3](elastic/elastic-charts@v70.1.2...v70.1.3)
(2025-08-04)


### Bug Fixes

* update css style exports to use Borealis theme tokens
([#2695](elastic/elastic-charts#2695))
([5619e08](elastic/elastic-charts@5619e08))

##
[70.1.2](elastic/elastic-charts@v70.1.1...v70.1.2)
(2025-07-23)


### Bug Fixes

* **axis:** disable nice adaptive ticks
([#2689](elastic/elastic-charts#2689))
([5f9d946](elastic/elastic-charts@5f9d946))

##
[70.1.1](elastic/elastic-charts@v70.1.0...v70.1.1)
(2025-07-14)
---

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:axis Axis related issue :data Data/series/scales related issue :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants