-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganization of the Sphinx docs to only include reference pages #2776
base: main
Are you sure you want to change the base?
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we should wait for HTTP redirects to be in place before merging IMO.
Including a redirect from /api.html to /index.html.
@pquentin Redirect table proposal:
The And aside from this, it is unfortunate but I think we are going to have to create redirects for each version that we publish, until we decide this isn't necessary anymore, because we want the <= 8.17 docs to be redirect free, meaning that we cannot do generic redirects across all versions. |
Yes, good point.
That makes sense. The free plan we're using allows for 100 redirects, but I'm assuming we will only need redirects for latest, stable, 8.18, 8.19, 9.0 and 9.1, not much more than that? |
All pages renamed so that there are no collisions with the redirects. I guess we can wait until the new docs system is in place to see if the redirects above need to be adjusted, and only merge this PR after we put those in. |
20a2385
to
6d14ceb
Compare
Rebased to incorporate minor changes made during the docs migration to markdown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this renamed? This is going to break existing links, I believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to avoid collisions when we add the redirects. Look at the table above. Requests to /en/latest/api.html
will be redirected to /en/latest/index.html
, since now the whole site is reference documentation. This page is renamed because if not there would be no way to create a direct link to it, given that it collides with the redirect.
Side note, the URLs under the new doc system are different, so the second column of the redirect table above needs to be updated to match the markdown doc URLs (and hopefully the docs team have added their own redirects from the old URLs to the new.)
Python Elasticsearch Client | ||
=========================== | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link to the main docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should add links to the guide in all the reference pages where there is a reasonable page to link to. I'm looking into this.
@pquentin I have updated the redirect table. It now has redirects for 8.18 and 9.0+ separately. I need to confirm that I've got the 9.0 links right, since these are not deployed yet and I'm building them based on previews and descriptions of what the URL system is going to be. Can you confirm that this looks good? |
Sounds good! We can set up the 9.0 redirects when the docs are live. Yes, es-api.html, makes sense. Thank you for this work |
Reorganization of the Sphinx docs to only include reference pages.