-
Notifications
You must be signed in to change notification settings - Fork 117
Document the append processor's media_type #5861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
|
I added some |
Thanks for asking! Changes often break clients in surprising ways. In this case:
Our backporting policy is mentioned at the end of CONTRIBUTING.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Looks like we don't have YAML tests for this, so it can't be validated.
(By the way, this would be nicer as an enum, but I think that would be breaking.)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5861-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4000de2b5e0621618e7249684a566e986889845b
# Push it to GitHub
git push --set-upstream origin backport-5861-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5861-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4000de2b5e0621618e7249684a566e986889845b
# Push it to GitHub
git push --set-upstream origin backport-5861-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5861-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4000de2b5e0621618e7249684a566e986889845b
# Push it to GitHub
git push --set-upstream origin backport-5861-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-5861-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4000de2b5e0621618e7249684a566e986889845b
# Push it to GitHub
git push --set-upstream origin backport-5861-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2Then, create a pull request where the |
* Add default value of the set processor's media_type * The append processor also has a media_type * make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 4000de2) # Conflicts: # output/schema/schema.json
* Add default value of the set processor's media_type * The append processor also has a media_type * make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 4000de2) # Conflicts: # output/openapi/elasticsearch-openapi.json # output/openapi/elasticsearch-serverless-openapi.json # output/schema/schema.json # output/typescript/types.ts # specification/ingest/_types/Processors.ts
* Add default value of the set processor's media_type * The append processor also has a media_type * make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 4000de2) # Conflicts: # output/openapi/elasticsearch-openapi.json # output/openapi/elasticsearch-serverless-openapi.json # output/schema/schema.json # output/typescript/types.ts # specification/ingest/_types/Processors.ts
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Add default value of the set processor's media_type * The append processor also has a media_type * make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 4000de2) # Conflicts: # output/schema/schema.json Co-authored-by: Joe Gallo <[email protected]>
* Add default value of the set processor's media_type * The append processor also has a media_type * make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 4000de2) # Conflicts: # output/openapi/elasticsearch-openapi.json # output/openapi/elasticsearch-serverless-openapi.json # output/schema/schema.json # output/typescript/types.ts # specification/ingest/_types/Processors.ts Co-authored-by: Joe Gallo <[email protected]>
* Add default value of the set processor's media_type * The append processor also has a media_type * make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 4000de2) # Conflicts: # output/openapi/elasticsearch-openapi.json # output/openapi/elasticsearch-serverless-openapi.json # output/schema/schema.json # output/typescript/types.ts # specification/ingest/_types/Processors.ts Co-authored-by: Joe Gallo <[email protected]>
The
setprocessor'smedia_typedidn't document that there's a default value of"application/json", which I've fixed. More than that, though, theappendprocessor also has amedia_typethat behaves the same way.Neither of these things are new, they've both been this way more or less forever -- I don't know how backports and whatnot are handled on this repo, though. Can you help me with that, @pquentin?