Skip to content

Conversation

@joegallo
Copy link
Contributor

The set processor's media_type didn't document that there's a default value of "application/json", which I've fixed. More than that, though, the append processor also has a media_type that behaves the same way.

Neither of these things are new, they've both been this way more or less forever -- I don't know how backports and whatnot are handled on this repo, though. Can you help me with that, @pquentin?

@elastic elastic deleted a comment from github-actions bot Dec 17, 2025
@github-actions
Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@joegallo
Copy link
Contributor Author

I added some backport labels to cover all 9.x branches and the last 8.x branch. I don't know if what's ordinary for changes like this on this repo, though, so please tell me if we're should do something else.

@pquentin
Copy link
Member

pquentin commented Jan 5, 2026

Neither of these things are new, they've both been this way more or less forever -- I don't know how backports and whatnot are handled on this repo, though. Can you help me with that, @pquentin?

Thanks for asking! Changes often break clients in surprising ways. In this case:

  • Server defaults are only useful for docs, so they can be backported.
  • Optional fields are also not breaking, so backporting is fine too.

Our backporting policy is mentioned at the end of CONTRIBUTING.md.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Looks like we don't have YAML tests for this, so it can't be validated.

(By the way, this would be nicer as an enum, but I think that would be breaking.)

@pquentin pquentin merged commit 4000de2 into main Jan 5, 2026
10 checks passed
@pquentin pquentin deleted the append-processor-media-type branch January 5, 2026 12:08
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5861-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4000de2b5e0621618e7249684a566e986889845b
# Push it to GitHub
git push --set-upstream origin backport-5861-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5861-to-8.19.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5861-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4000de2b5e0621618e7249684a566e986889845b
# Push it to GitHub
git push --set-upstream origin backport-5861-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-5861-to-9.0.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The backport to 9.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5861-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4000de2b5e0621618e7249684a566e986889845b
# Push it to GitHub
git push --set-upstream origin backport-5861-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1

Then, create a pull request where the base branch is 9.1 and the compare/head branch is backport-5861-to-9.1.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The backport to 9.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-5861-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4000de2b5e0621618e7249684a566e986889845b
# Push it to GitHub
git push --set-upstream origin backport-5861-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2

Then, create a pull request where the base branch is 9.2 and the compare/head branch is backport-5861-to-9.2.

pquentin pushed a commit that referenced this pull request Jan 5, 2026
* Add default value of the set processor's media_type

* The append processor also has a media_type

* make contrib

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 4000de2)

# Conflicts:
#	output/schema/schema.json
pquentin pushed a commit that referenced this pull request Jan 5, 2026
* Add default value of the set processor's media_type

* The append processor also has a media_type

* make contrib

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 4000de2)

# Conflicts:
#	output/openapi/elasticsearch-openapi.json
#	output/openapi/elasticsearch-serverless-openapi.json
#	output/schema/schema.json
#	output/typescript/types.ts
#	specification/ingest/_types/Processors.ts
pquentin pushed a commit that referenced this pull request Jan 5, 2026
* Add default value of the set processor's media_type

* The append processor also has a media_type

* make contrib

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 4000de2)

# Conflicts:
#	output/openapi/elasticsearch-openapi.json
#	output/openapi/elasticsearch-serverless-openapi.json
#	output/schema/schema.json
#	output/typescript/types.ts
#	specification/ingest/_types/Processors.ts
@pquentin
Copy link
Member

pquentin commented Jan 5, 2026

💚 All backports created successfully

Status Branch Result
9.2
9.1
8.19

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Jan 5, 2026
* Add default value of the set processor's media_type

* The append processor also has a media_type

* make contrib

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 4000de2)

# Conflicts:
#	output/schema/schema.json

Co-authored-by: Joe Gallo <[email protected]>
pquentin added a commit that referenced this pull request Jan 5, 2026
* Add default value of the set processor's media_type

* The append processor also has a media_type

* make contrib

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 4000de2)

# Conflicts:
#	output/openapi/elasticsearch-openapi.json
#	output/openapi/elasticsearch-serverless-openapi.json
#	output/schema/schema.json
#	output/typescript/types.ts
#	specification/ingest/_types/Processors.ts

Co-authored-by: Joe Gallo <[email protected]>
pquentin added a commit that referenced this pull request Jan 5, 2026
* Add default value of the set processor's media_type

* The append processor also has a media_type

* make contrib

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 4000de2)

# Conflicts:
#	output/openapi/elasticsearch-openapi.json
#	output/openapi/elasticsearch-serverless-openapi.json
#	output/schema/schema.json
#	output/typescript/types.ts
#	specification/ingest/_types/Processors.ts

Co-authored-by: Joe Gallo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants