Fix assertion in DiskThresholdDeciderIT (part 2)
#127846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the final assertion in testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleRestores() that wasn't addressed with the fix in PR 127615 for issue 127286. Closes elastic#127787
JeremyDahlgren
added
>test
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
reviewed
May 12, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Test was muted - this PR should remove the mute; also I left a comment.
...erTest/java/org/elasticsearch/cluster/routing/allocation/decider/DiskThresholdDeciderIT.java
Show resolved
Hide resolved
DaveCTurner
approved these changes
May 12, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM (one request for a code comment)
...erTest/java/org/elasticsearch/cluster/routing/allocation/decider/DiskThresholdDeciderIT.java
Show resolved
Hide resolved
Co-authored-by: David Turner <[email protected]>
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
JeremyDahlgren
added a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
May 12, 2025
Fixes the final assertion in testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleRestores() that wasn't addressed with the fix in PR 127615 for issue 127286. Closes elastic#127787 Co-authored-by: David Turner <[email protected]> (cherry picked from commit 98296d7) # Conflicts: # muted-tests.yml
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
JeremyDahlgren
added a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
May 12, 2025
Fixes the final assertion in testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleRestores() that wasn't addressed with the fix in PR 127615 for issue 127286. Closes elastic#127787 Co-authored-by: David Turner <[email protected]> (cherry picked from commit 98296d7) # Conflicts: # muted-tests.yml
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
JeremyDahlgren
added a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
May 12, 2025
Fixes the final assertion in testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleRestores() that wasn't addressed with the fix in PR 127615 for issue 127286. Closes elastic#127787 Co-authored-by: David Turner <[email protected]> (cherry picked from commit 98296d7) # Conflicts: # muted-tests.yml
JeremyDahlgren
added a commit
that referenced
this pull request
May 13, 2025
Fixes the final assertion in testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleRestores() that wasn't addressed with the fix in PR 127615 for issue 127286. Closes #127787 Co-authored-by: David Turner <[email protected]> (cherry picked from commit 98296d7)
JeremyDahlgren
added a commit
that referenced
this pull request
May 13, 2025
Fixes the final assertion in testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleRestores() that wasn't addressed with the fix in PR 127615 for issue 127286. Closes #127787 Co-authored-by: David Turner <[email protected]> (cherry picked from commit 98296d7)
JeremyDahlgren
added a commit
that referenced
this pull request
May 13, 2025
Fixes the final assertion in testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleRestores() that wasn't addressed with the fix in PR 127615 for issue 127286. Closes #127787 Co-authored-by: David Turner <[email protected]> (cherry picked from commit 98296d7)
benchaplin
pushed a commit
to benchaplin/elasticsearch
that referenced
this pull request
May 20, 2025
Fixes the final assertion in testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleRestores() that wasn't addressed with the fix in PR 127615 for issue 127286. Closes elastic#127787 Co-authored-by: David Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the final assertion in
testRestoreSnapshotAllocationDoesNotExceedWatermarkWithMultipleRestores()that wasn't addressed with the fix in PR #127615 for issue #127286.To reproduce the failure more reliably on my local machine I forced
usableSpace = shardSizes.getSmallestShardSize()andindexRandom(true, indexName, 100)to build smaller shards and keep the usable space at the minimum.Closes #127787